From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: =?utf-8?B?0JbQsNGA0LrQvtCyINCg0L7QvNCw0L0=?= <r.zharkov@postgrespro.ru>,
        Badrul Chowdhury <bachow@microsoft.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Intermittent pg_ctl failures on Windows
In-reply-to: <20190719030208.GG1859@paquier.xyz>
References: <16922.1520722108@sss.pgh.pa.us>
 <DM5PR2101MB0984D3DB39BCCCF189ECD15ED1D30@DM5PR2101MB0984.namprd21.prod.outlook.com>
 <0057a0ce5a8893e4713a9a9d7e352162@postgrespro.ru>
 <26631.1563371508@sss.pgh.pa.us>
 <3b46fc8be044c79b5eff7d26c810d2fd@postgrespro.ru>
 <20190718085148.GI1416@paquier.xyz>
 <B9F855CF-1756-40FA-B9AF-1F48A9480269@postgrespro.ru>
 <20190719030208.GG1859@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 19 Jul 2019 12:02:08 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1579.1563512383.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 19 Jul 2019 00:59:43 -0400
Message-ID: <1580.1563512383@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jul 18, 2019 at 04:14:34PM +0700, Жарков Роман wrote:
>> I have tested clean REL_11_STABLE.
>> Commit f02259fe was reverted by df8b5f3e in this branch.
>> So pg_ctl uses “old” open() function.

> Yeah, that was a failure from me, so I tend to be rather very careful
> about anything related to Windows.  However, after that we have added 
> 40cfe86 about which nobody has complained yet, and the number of
> buildfarm failures about pg_ctl concurrency on HEAD has gone down to
> zero since (perhaps I am missing something?).

Hm, I think 0ba06e0 is actually the relevant change here?  Though
40cfe86 was a necessary cleanup fix.

I'm too tired to dig in the buildfarm database to be sure, but my
impression is that the failure rate is much-better-but-not-zero.
So I'd support back-patching those two commits, but I'm not sure
if that's the end of the conversation.

			regards, tom lane