From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ecpg_config.h symbol missing with meson
In-reply-to: <bf35d032-02fc-4173-9f4f-840999cc3ef3@eisentraut.org>
References: <bf35d032-02fc-4173-9f4f-840999cc3ef3@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Wed, 17 Apr 2024 16:48:22 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1580076.1713370500.1@sss.pgh.pa.us>
Date: Wed, 17 Apr 2024 12:15:00 -0400
Message-ID: <1580077.1713370500@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1580077.1713370500%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> I checked the generated ecpg_config.h with make and meson, and the meson 
> one is missing

> #define HAVE_LONG_LONG_INT 1

> This is obviously quite uninteresting, since that is required by C99. 
> But it would be more satisfactory if we didn't have discrepancies like 
> that.  Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for 
> compatibility.
> ...
> Alternatively, we could remove the symbol from the make side.

Think I'd vote for removing it, since we use it nowhere.
The ENABLE_THREAD_SAFETY precedent feels a little bit different,
since there's not the C99-requires-the-feature angle.

			regards, tom lane