Date: Fri, 31 Jan 2020 14:59:48 -0700 (MST)
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Message-ID: <1580507988788-0.post@n3.nabble.com>
In-Reply-To: <72558.1579188350@antos>
References: 
 <CAN_9JTy95UMjOVDSc-4MBrA6Fc1hX2vh=t2RMHp=yGyAV=-Xsw@mail.gmail.com>
 <1897.1562680064@spoje.net>
 <CAN_9JTzC1K-Gc3p5GD=dQeJD8k_Z5996B0rEYjVGx+pXPq8JPw@mail.gmail.com>
 <13971.1562920911@spoje.net>
 <CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
 <19857.1563374392@localhost> <20190904202339.GA13644@alvherre.pgsql>
 <7087.1567663858@localhost> <20200111011124.efacqhdsptc36pm2@development>
 <72558.1579188350@antos>
Subject: Re: WIP: Aggregation push-down
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

Thank you for this great feature !
I hope this will be reviewed/validated soon ;o)

Just a comment:
set enable_agg_pushdown to true;
isn't displayed in EXPLAIN (SETTINGS) syntax.


The following modification seems to fix that: 

src/backend/utils/misc/guc.c
 
 		{"enable_agg_pushdown", PGC_USERSET, QUERY_TUNING_METHOD,
			gettext_noop("Enables aggregation push-down."),
			NULL,
			GUC_EXPLAIN   <<<<--- line Added --->>>>
		},
		&enable_agg_pushdown,
		false,
		NULL, NULL, NULL
	},


then
postgres=# set enable_agg_pushdown = true;
SET
postgres=# explain (settings) select 1;
                QUERY PLAN
------------------------------------------
 Result  (cost=0.00..0.01 rows=1 width=4)
 Settings: enable_agg_pushdown = 'on'
(2 rows)


Regards
PAscal


--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html