From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        Andres Freund <andres@anarazel.de>,
        Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Subject: Re: error context for vacuum to include block number
In-reply-to: <20200220170236.GA16805@alvherre.pgsql>
References: <20200220170236.GA16805@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 20 Feb 2020 14:02:36 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15822.1582222226.1@sss.pgh.pa.us>
Date: Thu, 20 Feb 2020 13:10:26 -0500
Message-ID: <15823.1582222226@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Another point is that this patch seems to be leaking memory each time
> you set relation/index/namespace name, since you never free those and
> they are changed over and over.

One other point is that this code seems to be trying to ensure that
the error context callback itself won't need to touch the catalog cache or
relcache, which is an important safety feature ... but it's failing at
that goal, because RelationGetRelationName() is going to hand back a
pointer to a string in the relcache.  You need another pstrdup for that.

			regards, tom lane