Date: Thu, 27 Feb 2020 14:35:55 -0700 (MST)
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Message-ID: <1582839355247-0.post@n3.nabble.com>
In-Reply-To: <1577490124579-0.post@n3.nabble.com>
References: <20191129130053.b2cdf2303ff35e437dd39571@sraoss.co.jp>
 <CA+HiwqFHvD5ZuewZ+srr+er6yoZu9tD_Pdjxu8G2vBvKPyQe=Q@mail.gmail.com>
 <20191129181600.7b5dd4167e1753536af33937@sraoss.co.jp>
 <20191129181954.208da0d63c1ff9e556008e80@sraoss.co.jp>
 <20191201025514.GY2355@paquier.xyz>
 <20191202.100118.1160224336488931090.t-ishii@sraoss.co.jp>
 <20191202110538.a6ff2cd84f488f42eab621eb@sraoss.co.jp>
 <20191220140232.57b43c4f6296f793d42946b2@sraoss.co.jp>
 <20191226110302.6e85967388aea26292dde1b5@sraoss.co.jp>
 <1577490124579-0.post@n3.nabble.com>
Subject: Re: Implementing Incremental View Maintenance
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

> I have tried to use an other patch with yours:
> "Planning counters in pg_stat_statements (using pgss_store)"

> setting
> shared_preload_libraries='pg_stat_statements'
> pg_stat_statements.track=all
> restarting the cluster and creating the extension


> When trying following syntax:

> create table b1 (id integer, x numeric(10,3));
> create incremental materialized view mv1 as select id, count(*),sum(x) 
> from b1 group by id;
> insert into b1 values (1,1)
>
> I got an ASSERT FAILURE in pg_stat_statements.c
> on
> 	Assert(query != NULL);
>
> comming from matview.c
>	refresh_matview_datafill(dest_old, query, queryEnv, NULL);
> or
>	refresh_matview_datafill(dest_new, query, queryEnv, NULL);
>
> If this (last) NULL field was replaced by the query text, 
> a comment or just "n/a",
> it would fix the problem.

> Could this be investigated ?

Hello,

thank you for patch v14, that fix problems inherited from temporary tables.
it seems that this ASSERT problem with pgss patch is still present ;o(

Could we have a look ?

Thanks in advance
Regards
PAscal


--
Sent from:
https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html


--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html