Date: Fri, 28 Feb 2020 08:06:35 -0700 (MST)
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Message-ID: <1582902395847-0.post@n3.nabble.com>
In-Reply-To: 
 <CAOBaU_YwuN2k9Ays8mKq0pS8ZjLsf7zMWRFk8yb-MF0O5to_cA@mail.gmail.com>
References: 
 <OSBPR01MB46160534A6DF796D180FA88E94700@OSBPR01MB4616.jpnprd01.prod.outlook.com>
 <CAOBaU_YKtC78KmEc_W98yz=BGKd3Lgx-q7D37_sTA9VdsW+xOQ@mail.gmail.com>
 <OSBPR01MB461651369C5B06C4BAEDF4D3944F0@OSBPR01MB4616.jpnprd01.prod.outlook.com>
 <CAOBaU_bZwSHVNVX_v3+_vqmrvAE0gcp6YczWS1kL74LUZ=fMgQ@mail.gmail.com>
 <OSBPR01MB46160EE594D4C0261C0A4B7694490@OSBPR01MB4616.jpnprd01.prod.outlook.com>
 <CAOBaU_bKDoMxEWLqJue8ZS-kamcwKS2zUROONjEtp_sHmbBegg@mail.gmail.com>
 <1578237055901-0.post@n3.nabble.com>
 <CAOBaU_Z9AyNbsgXmdeQeRAknjqeRfeBEDT8F8Q35DFLQU37g3A@mail.gmail.com>
 <1578247319224-0.post@n3.nabble.com>
 <CAOBaU_YwuN2k9Ays8mKq0pS8ZjLsf7zMWRFk8yb-MF0O5to_cA@mail.gmail.com>
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Julien,

>> But I would have prefered this new feature to work the same way with or
>> without track_planning activated ;o(

> Definitely, but fixing the issue in pgss (ignoring planner calls when
> we don't have a query text) means that pgss won't give an exhaustive
> view of activity anymore, so a fix in IVM would be a better solution.
> Let's wait and see if Nagata-san and other people involved in that
> have an opinion on it.

It seems IVM team does not consider this point as a priority ... 
We should not wait for them, if we want to keep a chance to be 
included in PG13.

So we have to make this feature more robust, an assert failure being 
considered as a severe regression (even if this is not coming from pgss).

I like the idea of adding a check for a non-zero queryId in the new 
pgss_planner_hook() (zero queryid shouldn't be reserved for
utility_statements ?).

Fixing the corner case where a query (with no sql text) can be planned 
without being parsed is an other subject that should be resolved in an 
other thread.

This kind of query was ignored in pgss, it should be ignored in pgss with 
planning counters.

Any thoughts ?
Regards
PAscal


--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html