From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
cc: Jim Nasby <Jim.Nasby@bluetreble.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Less than ideal error reporting in pg_stat_statements
In-reply-to: 
 <CAKJS1f-T97i7zMXjApYC-h1Gym2CQ0rWYNGtxn6HO+9zHabuTQ@mail.gmail.com>
References: <5601D354.5000703@BlueTreble.com>
 <CAKJS1f-T97i7zMXjApYC-h1Gym2CQ0rWYNGtxn6HO+9zHabuTQ@mail.gmail.com>
Comments: In-reply-to David Rowley <david.rowley@2ndquadrant.com>
 message dated "Wed, 23 Sep 2015 10:48:38 +1200"
Date: Tue, 22 Sep 2015 19:38:05 -0400
Message-ID: <15837.1442965085@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

David Rowley <david.rowley@2ndquadrant.com> writes:
> On 23 September 2015 at 10:16, Jim Nasby <Jim.Nasby@bluetreble.com> wrote:
>>> Attached patch fixes, though I'm not sure if %lld is portable or not.

It is not.

> I think you could probably use INT64_FORMAT,

Not in a message you expect to be translatable.

There are ways around that, but TBH I do not think that including the file
size in the errdetail is valuable enough to be worth the trouble.  I'd
just leave it out.  "insufficient memory to load statement file" seems
quite enough.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers