From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Tristan Partin" <tristan@neon.tech>
cc: pgsql-hackers@postgresql.org
Subject: Re: psql not responding to SIGINT upon db reconnection
In-reply-to: <CUAKIOVISECO.2S7MSQFOP1304@gonk>
References: <CUAJJDVD8L61.2AH6VEEDMTXX3@gonk> <CUAKHCX5472I.SJP0AWQRYVFA@gonk>
 <CUAKIOVISECO.2S7MSQFOP1304@gonk>
Comments: In-reply-to "Tristan Partin" <tristan@neon.tech>
	message dated "Mon, 24 Jul 2023 12:11:27 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1588057.1690220636.1@sss.pgh.pa.us>
Date: Mon, 24 Jul 2023 13:43:56 -0400
Message-ID: <1588058.1690220636@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1588058.1690220636%40sss.pgh.pa.us>
Precedence: bulk

"Tristan Partin" <tristan@neon.tech> writes:
> v3 is attached which fixes up some code comments I added which I hadn't 
> attached to the commit already, sigh.

I don't care for this patch at all.  You're bypassing the pqsignal
abstraction layer that the rest of psql goes through, and the behavior
you're implementing isn't very nice.  People do not expect ^C to
kill psql - it should just stop the \c attempt and leave you as you
were.

Admittedly, getting PQconnectdbParams to return control on SIGINT
isn't too practical.  But you could probably replace that with a loop
around PQconnectPoll and test for CancelRequested in the loop.

			regards, tom lane