From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
In-reply-to: <3053249.1615834191@sss.pgh.pa.us>
References: <951335.1612910077@sss.pgh.pa.us>
 <20210209230155.GA551305@rfd.leadboat.com> <1477413.1613068373@sss.pgh.pa.us>
 <b7ef059e-4897-d2c2-62cb-7c5ebdc40f3e@dunslane.net>
 <3053249.1615834191@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 15 Mar 2021 14:49:51 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1593064.1617809014.1@sss.pgh.pa.us>
Date: Wed, 07 Apr 2021 11:23:34 -0400
Message-ID: <1593065.1617809014@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1593065.1617809014%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> We can't allow '-', for the specific reason that it won't work as a -c
> argument (thanks to -c's translation of '-' to '_').  The whole point here
> is to prevent corner cases like that.  ':' would be all right, but I think
> it's a lot simpler to explain and a lot harder to break in future if we
> just say that the names have to be valid identifiers.

Hearing no further comments, I pushed the more restrictive version.

			regards, tom lane