Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nEqBR-0000AX-Vb
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Feb 2022 10:14:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nEqBQ-0000YI-HC
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Feb 2022 10:14:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <ah@cybertec.at>)
	id 1nEqBQ-0000Xq-3l
	for pgsql-hackers@lists.postgresql.org; Tue, 01 Feb 2022 10:14:44 +0000
Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <ah@cybertec.at>)
	id 1nEqBN-0006cA-1V
	for pgsql-hackers@lists.postgresql.org; Tue, 01 Feb 2022 10:14:42 +0000
Received: by mail-ej1-x62e.google.com with SMTP id ka4so52410482ejc.11
        for <pgsql-hackers@lists.postgresql.org>; Tue, 01 Feb 2022 02:14:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=cybertec-at.20210112.gappssmtp.com; s=20210112;
        h=from:to:subject:mime-version:date:message-id;
        bh=t+swQhw+x07OLwskRkYLWjs00eeddHzRiIivPN0LzcM=;
        b=KIf5NezvVQ1ZCsmVKNLuIxjaE5V8yuV0nVP2TYTJjXOjExBPLFR3UHUmZqNNj3rqv6
         vh/ihEKsFFH+LuMdvm8J8IZnZ/hlYsh0ZQjcHA31kA9WXuA0rUxECz/FStkVVXGmInC5
         31iVd1kidapwPr9thgmGY3iAZeZw5SV1gYM43y9UA/CUgmZLYkfmpGZbKsC64s1HTS0C
         EPrYlKb22zv2LOvmeCJAbh9CVnNIVs1IpXD/JehSOiDEekVpbP08S0A3+7Zqf+tB4+k7
         mz6MOtdMyA+qe8F2lZ2WKiUriwwVt9wLZQ+0gAmdnztDTcXBnesi4AzndnWjQG3hdcv7
         E95w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:subject:mime-version:date:message-id;
        bh=t+swQhw+x07OLwskRkYLWjs00eeddHzRiIivPN0LzcM=;
        b=1WitoxRk9Epay0G+iXPPAwSF8sCEAER7lSdwRxJcIdh41MPTz1JyBw62S+Rz9WNGM7
         sxeyiUaDq4EQsBYY9otLtciFjuhYF7xjXxzZ9D2aqs12aEzpsqybB8S/LAZJf+PyKUj2
         Z90LcsnEdJipEkMR5Oy5CmeQRNWtIGtHsyTFTUaOaGWpzjvdzqDSgJ2lixUMbKNtdBGi
         99FyeVBtSWJ8DVqOUPwlwaQooobG85yowf1YCaFbYE9tHIymqdw4qx9lQJlhi0TlstrW
         w4URCYkjI3Q7MD2fXxIlqj1QNijIIOIo9zcB4Q2rbOb5/vgbTEbLCQqCM4QiRzWSalxT
         lJzw==
X-Gm-Message-State: AOAM5334gtVpMvEBlUUCEa28ZoA5jbcwlp9uCCGpP3p6y4GpOXWxmlph
	jMtkDU02XAhMbbMN/1XKu3+LCpPkK4Dlww==
X-Google-Smtp-Source: ABdhPJwtOqS3FfKFiDXUj2QCBArwCUJYwm6wKFnmV8a35iw+36ONBAZvvBG7Na9GY+gD29J9JP+8bA==
X-Received: by 2002:a17:907:2d0d:: with SMTP id gs13mr20441932ejc.161.1643710479280;
        Tue, 01 Feb 2022 02:14:39 -0800 (PST)
Received: from antos (85-207-121-76.static.bluetone.cz. [85.207.121.76])
        by smtp.gmail.com with ESMTPSA id bx18sm15877974edb.93.2022.02.01.02.14.38
        for <pgsql-hackers@lists.postgresql.org>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 01 Feb 2022 02:14:38 -0800 (PST)
From: Antonin Houska <ah@cybertec.at>
To: pgsql-hackers@lists.postgresql.org
Subject: Doc: CREATE_REPLICATION_SLOT command requires the plugin name
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 27.2.50
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Tue, 01 Feb 2022 11:16:48 +0100
Message-ID: <15946.1643710608@antos>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/15946.1643710608%40antos>
Precedence: bulk

--=-=-=
Content-Type: text/plain

I got a syntax error when using the command according to the existing
documentation. The output_plugin parameter needs to be passed too.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=doc_create_replication_slot.diff

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 24e93f9b28..6065c18fdf 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -1942,7 +1942,7 @@ The commands accepted in replication mode are:
   </varlistentry>
 
   <varlistentry id="protocol-replication-create-slot" xreflabel="CREATE_REPLICATION_SLOT">
-   <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
+   <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> <replaceable class="parameter">output_plugin</replaceable> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
      <indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm>
     </term>
     <listitem>

--=-=-=--