From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Robert Haas <robertmhaas@gmail.com>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Amit Langote <amitlangote09@gmail.com>,
        Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        Jesper Pedersen <jesper.pedersen@redhat.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        Beena Emerson <memissemerson@gmail.com>, amul sul <sulamul@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: [HACKERS] Runtime Partition Pruning
In-reply-to: <d4903af2-e7b7-b551-71f8-3e4a6bdc2e73@2ndquadrant.com>
References: <20180410213203.nl645o5vj5ap66sl@alvherre.pgsql>
 <d4903af2-e7b7-b551-71f8-3e4a6bdc2e73@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 24 May 2019 16:50:04 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <16006.1558711252.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 24 May 2019 11:20:52 -0400
Message-ID: <16007.1558711252@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2018-04-10 23:32, Alvaro Herrera wrote:
>> To figure out, I used the attached patch (not intended for application)
>> to add a backtrace to each log message, plus a couple of accusatory
>> elog() calls in relation_open and ExecSetupPartitionPruneState.

> What do people think about adding something like this errbacktrace()
> from Álvaro's patch to core PostgreSQL?  If we could devise a way to
> selectively enable it, it might be an easier way for users to provide
> backtraces from errors.

I think we did discuss it right after that, or somewhere nearby, and
concluded that the output is so imprecise that it's not really going
to be worth whatever portability issues we'd have to deal with.

I'd be all for a better version, but glibc's backtrace() just sucks,
at least given our coding style with lots of static functions.

			regards, tom lane