From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>
cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Amit Langote <amitlangote09@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        "Pg Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: speeding up planning with partitions
In-reply-to: <0F97FA9ABBDBE54F91744A9B37151A5127E7D2@g01jpexmbkw24>
References: <8ea8bbb1-31ff-a469-02a7-281c3eba4bea@lab.ntt.co.jp>
 <201902011001.4v25uw6w6kb5@alvherre.pgsql>
 <CAKJS1f9LkQ=w4cq2_OaW05=mw8H_jQofWHiK0w3VVP-nSkUUmA@mail.gmail.com>
 <CA+HiwqFioAonMAgE0OWZeK=NEEOKmq-c=iYR2pkPOO=q6NxMkg@mail.gmail.com>
 <e85c4b41-80d6-1045-d934-feeca4a463ab@lab.ntt.co.jp>
 <0F97FA9ABBDBE54F91744A9B37151A5127865E@g01jpexmbkw24>
 <5d00eb35-375d-0672-0626-96bdb86829d0@lab.ntt.co.jp>
 <CAKJS1f9XAePd2+8F4=wtHKdDdckgKcSoXb-ZbU8Wbt86mhLxKA@mail.gmail.com>
 <b8a139b8-2f5d-6079-67b2-99957af3fc36@lab.ntt.co.jp>
 <30972.1550510855@sss.pgh.pa.us>
 <0F97FA9ABBDBE54F91744A9B37151A5127E7D2@g01jpexmbkw24>
Comments: In-reply-to "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>
	message dated "Tue, 19 Feb 2019 00:49:28 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16014.1550540204.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 18 Feb 2019 20:36:44 -0500
Message-ID: <16015.1550540204@sss.pgh.pa.us>
Precedence: bulk

"Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com> writes:
> ISTM the 0004 patch eventually removes these codes from multiple places =
(set_append_rel_size and set_inherited_target_rel_sizes) so we might be be=
tter to not be struggling here?

Yeah, Amit just pointed that out (and I'd not read 0004 before reacting to
0001).  If the final state of the code isn't going to look like this, then
whether the intermediate state is good style becomes far less important.
Still, maybe it'd be better to drop the 0001 patch and absorb its effects
into the later patch that makes that if-test go away entirely.

			regards, tom lane