Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jIwGA-00049X-ND for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Mar 2020 15:23:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jIw8f-00041j-P8 for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Mar 2020 15:15:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIw8f-00041a-Hx for pgsql-hackers@lists.postgresql.org; Mon, 30 Mar 2020 15:15:45 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIw8d-0006dd-I2 for pgsql-hackers@lists.postgresql.org; Mon, 30 Mar 2020 15:15:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 02UFFf57016025; Mon, 30 Mar 2020 11:15:41 -0400 From: Tom Lane To: Michael Paquier cc: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha , PostgreSQL Hackers Subject: Re: Can we get rid of GetLocaleInfoEx() yet? In-reply-to: <20200330075750.GE43995@paquier.xyz> References: <24905.1585445371@sss.pgh.pa.us> <28339.1585501223@sss.pgh.pa.us> <20200330075750.GE43995@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Mon, 30 Mar 2020 16:57:50 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <16023.1585581341.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 30 Mar 2020 11:15:41 -0400 Message-ID: <16024.1585581341@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Sun, Mar 29, 2020 at 07:06:56PM +0200, Juan Jos=C3=A9 Santamar=C3=ADa= Flecha wrote: >> It works for the issue just fine, and more comments make a better a >> patch, so no objections from me. > +1 from me. And yes, we are still missing lc_codepage in newer > versions of VS. Locales + Windows !=3D 2, business as usual. OK, pushed. regards, tom lane