public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Harmonizing pg_bsd_indent parameter names
Date: Wed, 12 Jun 2024 17:33:34 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAH2-WzkaBS8w-vCbG5M5Bx7XikC0WhNLJV_+Z_YAWW9Kef6OBQ@mail.gmail.com>
References: <CAH2-WzkaBS8w-vCbG5M5Bx7XikC0WhNLJV_+Z_YAWW9Kef6OBQ@mail.gmail.com>

Peter Geoghegan <[email protected]> writes:
> Attached patch harmonizes pg_bsd_indent's function parameter names, so
> that they match the names used in corresponding function definitions.

Hmm, these aren't really harmonizing inconsistencies, but overruling
somebody's style decision to leave parameter names out of the extern
declarations.  That's a style I don't like personally, but some do.

> I have been putting this off because I wasn't sure that the policy
> should be the same for pg_bsd_indent. Is there any reason to think
> that this will create more work down the line? It seems like it might,
> due to some kind of need to keep pg_bsd_indent's consistent with
> upstream BSD indent.

We are, at least in theory, trying to stay within hailing distance
of the upstream; that's the primary reason why we've not touched
the indentation style of pg_bsd_indent itself.  Still, two lines
is not going to make much of a difference in whether patches can
be passed back and forth (whereas reindentation would kill that
somewhat thoroughly).

Anyway, after chewing on it for a few minutes, no objection here.

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Harmonizing pg_bsd_indent parameter names
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox