Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVfG8-0000mT-6h for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jul 2017 14:38:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dVfG7-0003Ww-L3 for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jul 2017 14:38:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dVfEX-0002GY-6f for pgsql-hackers@postgresql.org; Thu, 13 Jul 2017 14:36:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dVfEU-0004LX-Us for pgsql-hackers@postgresql.org; Thu, 13 Jul 2017 14:36:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v6DEagJT016094; Thu, 13 Jul 2017 10:36:42 -0400 From: Tom Lane To: Andrew Dunstan cc: Ashutosh Sharma , Dave Page , Sandeep Thakkar , "pgsql-hackers@postgresql.org" Subject: Re: pl/perl extension fails on Windows In-reply-to: <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> References: <4569.1499873707@sss.pgh.pa.us> <6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com> <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> Comments: In-reply-to Andrew Dunstan message dated "Thu, 13 Jul 2017 08:34:28 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16092.1499956602.1@sss.pgh.pa.us> Date: Thu, 13 Jul 2017 10:36:42 -0400 Message-ID: <16093.1499956602@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andrew Dunstan writes: > On 07/13/2017 08:08 AM, Ashutosh Sharma wrote: >> - dVAR; dXSBOOTARGSAPIVERCHK; >> + dVAR; dXSBOOTARGSNOVERCHK; > Good job hunting this down! > One suggestion I saw in a little googling was that we add this to the XS > file after the inclusion of XSUB.h: > #undef dXSBOOTARGSAPIVERCHK > #define dXSBOOTARGSAPIVERCHK dXSBOOTARGSNOVERCHK I don't see anything even vaguely like that in the Util.c file generated by Perl 5.10.1, which is what I've got on my RHEL machine. What I do notice is this in Util.xs: VERSIONCHECK: DISABLE which leads immediately to two questions: 1. Why is your version of xsubpp apparently ignoring this directive and generating a version check anyway? 2. Why do we have this directive in the first place? It does not seem to me like a terribly great idea to ignore low-level version mismatches. In the same vein, I'm suspicious of proposals to "fix" this problem by removing the version check, which seems to be where Ashutosh is headed. In the long run that seems certain to cause huge headaches. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers