Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tichW-000UB0-6s for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 17:08:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tichU-00B22g-5r for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 17:08:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tichT-00B22Y-SY for pgsql-hackers@lists.postgresql.org; Thu, 13 Feb 2025 17:08:32 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tichR-000cNc-2O for pgsql-hackers@postgresql.org; Thu, 13 Feb 2025 17:08:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1739466505; bh=YwgfS5/pUPao3Aq8fr06djDiNJ3EixvYX8eYNc846nE=; h=Message-ID:Date:User-Agent:To:From:Subject:From; b=u7KOzmJR0FD2GlvpBvToHm+JYq/wM8FL+oHOzbCJl4E0wIfUecgw68xc55yCC+BqP +YPMagQaAjxHNc0M/rKOg3jF/aNUP5TprX8pUZJJJW8ssQop9ROuAZdHfq27JqAESJ ipfSYJerLOrJWulZJCytFeP8WHwnF58zrGiH+NWwjc61m0FBkOsVcaDZagDuwdR/O+ sJP6ZxA7j+kcX/gAPhvqSVE1lTe3Uq/ukTCVlcnQtrwHK8aR90arnpESdWz/gnZZc4 b2jUHkBvgvLjF1YjESM4KJlLpRetjMWtQNsvX4eSIQs61Mabkn0FWIKGUf2KIizGym YlO0dnaozearg== Received: from [172.30.49.74] (unknown [172.30.49.74]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: d.koval@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 37D56606B2 for ; Thu, 13 Feb 2025 20:08:25 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------4pre5q8xv9RNRIodB0QPmEhD" Message-ID: <1618848d-cdc7-414b-9c03-08cf4bef4408@postgrespro.ru> Date: Thu, 13 Feb 2025 20:08:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pgsql-hackers@postgresql.org From: Dmitry Koval Subject: Assignment before assert X-KSMG-AntiPhishing: NotDetected, bases: 2025/02/13 15:59:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/02/13 12:56:00 #27204040 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------4pre5q8xv9RNRIodB0QPmEhD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi! Function EvalPlanQualFetchRowMark contains an assignment ExecRowMark *erm = earm->rowmark; before assert Assert(earm != NULL); Maybe these lines need to be swapped? -- With best regards, Dmitry Koval Postgres Professional: http://postgrespro.com --------------4pre5q8xv9RNRIodB0QPmEhD Content-Type: text/plain; charset=UTF-8; name="v1-0001-fix-assignment-before-assert.patch" Content-Disposition: attachment; filename="v1-0001-fix-assignment-before-assert.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNNYWluLmMgYi9zcmMvYmFj a2VuZC9leGVjdXRvci9leGVjTWFpbi5jCmluZGV4IDM5ZDgwY2NmYmFkLi45NjNhYTM5MDYy MCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhlY01haW4uYworKysgYi9z cmMvYmFja2VuZC9leGVjdXRvci9leGVjTWFpbi5jCkBAIC0yNjYyLDEzICsyNjYyLDE1IEBA IGJvb2wKIEV2YWxQbGFuUXVhbEZldGNoUm93TWFyayhFUFFTdGF0ZSAqZXBxc3RhdGUsIElu ZGV4IHJ0aSwgVHVwbGVUYWJsZVNsb3QgKnNsb3QpCiB7CiAJRXhlY0F1eFJvd01hcmsgKmVh cm0gPSBlcHFzdGF0ZS0+cmVsc3Vic19yb3dtYXJrW3J0aSAtIDFdOwotCUV4ZWNSb3dNYXJr ICplcm0gPSBlYXJtLT5yb3dtYXJrOworCUV4ZWNSb3dNYXJrICplcm07CiAJRGF0dW0JCWRh dHVtOwogCWJvb2wJCWlzTnVsbDsKIAogCUFzc2VydChlYXJtICE9IE5VTEwpOwogCUFzc2Vy dChlcHFzdGF0ZS0+b3JpZ3Nsb3QgIT0gTlVMTCk7CiAKKwllcm0gPSBlYXJtLT5yb3dtYXJr OworCiAJaWYgKFJvd01hcmtSZXF1aXJlc1Jvd1NoYXJlTG9jayhlcm0tPm1hcmtUeXBlKSkK IAkJZWxvZyhFUlJPUiwgIkV2YWxQbGFuUXVhbCBkb2Vzbid0IHN1cHBvcnQgbG9ja2luZyBy b3dtYXJrcyIpOwogCg== --------------4pre5q8xv9RNRIodB0QPmEhD--