Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYNWh-00AQLh-0W for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 10:55:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tYNWf-00Adv3-Mx for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 10:55:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYNWf-00Adun-7N for pgsql-hackers@lists.postgresql.org; Thu, 16 Jan 2025 10:55:01 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYNWc-000hPV-0f for pgsql-hackers@postgresql.org; Thu, 16 Jan 2025 10:55:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1737024893; bh=QKZDAlqJe9asvCDnrBheT27ceUG+9i7kJA6qG85EAXs=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=AVYynkWl7Mij5dEwpsZWMpj5z7Bs6j/6pQBp2FXXzMt8MHunoH9rFfC2Xua+VPIuJ 53NSYKWV1xhvDuon2jvGMWEHjWxCAiaDio0e8pYFMjCWMMKmZi3+/Akx5jBbH/lSaE jSq80+Njdwu4YtfKtJspnKW5Ge6zRGj6TlY1rBlWptkJgQtsFuPgIja1lMZ1IV9q3v VnTFIISyI8ubbclSLY2NkeVfcUKKqZE5iepeYccbrselJVqe00BFqu/A2+Hk5m1zTD zmg8YW4NzQ1P+392BVovrO2tYZlfiv5KY6QLgTvpcPJThxiFI3PYFaG5M/N7clVSZS cJwtR8TgC9kwQ== Received: from [172.30.49.150] (unknown [172.30.49.150]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 97FFF5FF82; Thu, 16 Jan 2025 13:54:53 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------wtFmX4nNyt0ojT8an2aqGgKz" Message-ID: <16198d33-a4e2-46db-b6c3-494367f5816d@postgrespro.ru> Date: Thu, 16 Jan 2025 13:54:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Change GUC hashtable to use simplehash? To: Tom Lane Cc: John Naylor , Jeff Davis , Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Gurjeet Singh , pgsql-hackers@postgresql.org References: <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> <0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru> <1520769.1736991361@sss.pgh.pa.us> Content-Language: en-US From: "Anton A. Melnikov" In-Reply-To: <1520769.1736991361@sss.pgh.pa.us> X-KSMG-AntiPhishing: NotDetected, bases: 2025/01/16 09:51:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/01/16 07:50:00 #27039546 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------wtFmX4nNyt0ojT8an2aqGgKz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi! On 16.01.2025 04:36, Tom Lane wrote: > "Anton A. Melnikov" writes: >> Seems it is possible to exclude much less code from checking >> under valgrind and get the same result by replacing the only >> function call pg_rightmost_one_pos64() with a valgrind-safe >> code. See the attached patch, please. > > There is no place anywhere in our code base where we hide unsafe > code from valgrind rather than fixing said code. This does not > seem like a place to start such an ugly practice. Performance > does not trump everything else. Thanks for remark. Agreed. > I'd be inclined to just remove the pg_rightmost_one_pos64 call > in favor of the other coding you suggest. Here is a patch like that. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --------------wtFmX4nNyt0ojT8an2aqGgKz Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-Add-valgrind-safe-code-to-find-rightmost-bytes.patch" Content-Disposition: attachment; filename*0="v2-0001-Add-valgrind-safe-code-to-find-rightmost-bytes.patch" Content-Transfer-Encoding: base64 RnJvbSBiYWMyNmUwYzdlZTkwMDI0NmQ0NTRkZDk4ZGU0NWIzZWNlZmMxNWVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW50b24gQS4gTWVsbmlrb3YiIDxhLm1lbG5pa292 QHBvc3RncmVzcHJvLnJ1PgpEYXRlOiBUaHUsIDE2IEphbiAyMDI1IDAyOjU2OjUyICswMzAw ClN1YmplY3Q6IFtQQVRDSF0gVXNlIHZhbGdyaW5kLXNhZmUgY29kZSB0byBmaW5kIGEgbnVt YmVyIG9mIHJpZ2h0bW9zdCB6ZXJvCiBieXRlcy4KCi0tLQogc3JjL2luY2x1ZGUvY29tbW9u L2hhc2hmbl91bnN0YWJsZS5oIHwgMTYgKysrKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDExIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj L2luY2x1ZGUvY29tbW9uL2hhc2hmbl91bnN0YWJsZS5oIGIvc3JjL2luY2x1ZGUvY29tbW9u L2hhc2hmbl91bnN0YWJsZS5oCmluZGV4IGEwOWMwYjdkNWNlLi5mYTliOTU0YzZiOSAxMDA2 NDQKLS0tIGEvc3JjL2luY2x1ZGUvY29tbW9uL2hhc2hmbl91bnN0YWJsZS5oCisrKyBiL3Ny Yy9pbmNsdWRlL2NvbW1vbi9oYXNoZm5fdW5zdGFibGUuaApAQCAtMjk5LDE1ICsyOTksMjEg QEAgZmFzdGhhc2hfYWNjdW1fY3N0cmluZ19hbGlnbmVkKGZhc3RoYXNoX3N0YXRlICpocywg Y29uc3QgY2hhciAqc3RyKQogCiAJaWYgKGZpcnN0Ynl0ZTY0KGNodW5rKSAhPSAwKQogCXsK LQkJc2l6ZV90CQlyZW1haW5kZXI7CisJCXNpemVfdAkJcmVtYWluZGVyID0gMDsKIAkJdWlu dDY0CQltYXNrOwogCiAJCS8qCi0JCSAqIFRoZSBieXRlIGNvcnJlc3BvbmRpbmcgdG8gdGhl IE5VTCB3aWxsIGJlIDB4ODAsIHNvIHRoZSByaWdodG1vc3QKLQkJICogYml0IHBvc2l0aW9u IHdpbGwgYmUgaW4gdGhlIHJhbmdlIDE1LCAyMywgLi4uLCA2My4gVHVybiB0aGlzIGludG8K LQkJICogYnl0ZSBwb3NpdGlvbiBieSBkaXZpZGluZyBieSA4LgorCQkgKiBUaGUgYnl0ZSBj b3JyZXNwb25kaW5nIHRvIHRoZSBOVUwgdGVybWluYXRvciB3aWxsIGJlIHRoZSByaWdodG1v c3QgMHg4MC4KKwkJICogQWxsIHplcm8gYnl0ZXMgdG8gdGhlIHJpZ2h0IG9mIGl0IGNvcnJl c3BvbmQgdG8gdGhlIHRhaWwgb2YgdGhlIHN0cmluZy4KKwkJICogSXQgcmVtYWlucyB0byBj b3VudCB0aGVtLgogCQkgKi8KLQkJcmVtYWluZGVyID0gcGdfcmlnaHRtb3N0X29uZV9wb3M2 NCh6ZXJvX2J5dGVfbG93KSAvIEJJVFNfUEVSX0JZVEU7CisJCXdoaWxlICgoemVyb19ieXRl X2xvdyAmIDB4RkYpID09IDApCisJCXsKKwkJCXplcm9fYnl0ZV9sb3cgPj49IDg7CisJCQkr K3JlbWFpbmRlcjsKKwkJfQorCisJCUFzc2VydChyZW1haW5kZXIgIT0gMCk7CiAKIAkJLyoK IAkJICogQ3JlYXRlIGEgbWFzayBmb3IgdGhlIHJlbWFpbmluZyBieXRlcyBzbyB3ZSBjYW4g Y29tYmluZSB0aGVtIGludG8KLS0gCjIuNDguMQoK --------------wtFmX4nNyt0ojT8an2aqGgKz--