public inbox for [email protected]
help / color / mirror / Atom feedFrom: Cary Huang <[email protected]>
To: [email protected]
Cc: David Christensen <[email protected]>
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
Date: Mon, 28 Feb 2022 22:56:31 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hi
I am glad to find this patch here because it helps with my current development work, which involves a lot of debugging with the WAL records and this patch definitely make this much easier rather than using grep externally.
I have tried all of the new options added by the patch and every combination seems to result correctly.
The only comment I would have is in the documentation, where I would replace:
"Display only records touching the given block" with "Display only records associated with the given block"
"Display only records touching the given relation" with " Display only records associated with the given relation"
just to make it sound more formal. :)
best
Cary Huang
------------------
HighGo Software Canada
www.highgo.ca
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox