Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceomy-0006Jh-Cl for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Feb 2017 20:05:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ceomx-0002kx-Ma for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Feb 2017 20:05:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ceolX-00017n-NL for pgsql-hackers@postgresql.org; Fri, 17 Feb 2017 20:04:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ceolL-0003nx-Jp for pgsql-hackers@postgresql.org; Fri, 17 Feb 2017 20:04:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v1HK49BB016462; Fri, 17 Feb 2017 15:04:09 -0500 From: Tom Lane To: Andres Freund cc: pgsql-hackers@postgresql.org, Alvaro Herrera , Thomas Munro , Andrew Dunstan Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes In-reply-to: <0C821A10-45A2-4112-A1A2-EDAE27712C62@anarazel.de> References: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql> <32279.1487355685@sss.pgh.pa.us> <2664.1487360457@sss.pgh.pa.us> <0C821A10-45A2-4112-A1A2-EDAE27712C62@anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 17 Feb 2017 11:48:44 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16460.1487361849.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Feb 2017 15:04:09 -0500 Message-ID: <16461.1487361849@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andres Freund writes: > On February 17, 2017 11:40:57 AM PST, Tom Lane wrote: >> AFAICS, if you want to build with -Werror, you have to configure >> without that and then inject it afterwards. I wonder how people who >> use -Werror are handling that. Is it possible to do at all in a >> buildfarm critter? > Yea, I complained about that before. I think we'd have to add an extra co= nfigure option for it, because we rely in setting it only for certain tests= . Personally I use CEXTRA (IIRC) to achieve that result after configure r= an. [ pokes around... ] Ah, that's called COPT, and it's entirely undocumented :-(. Probably ought to fix that. regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers