From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Andreas Karlsson <andreas@proxel.se>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove useless casts to (void *)
In-reply-to: <8da4a1fc-5cd3-4414-a8a1-57929b85285c@eisentraut.org>
References: <461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org>
 <166213.1730211603@sss.pgh.pa.us>
 <3ab19dcf-7ca5-4de0-89b0-1ee344a42105@eisentraut.org>
 <c52898e7-b138-4c73-9ff1-52c7572c3f4b@proxel.se>
 <8da4a1fc-5cd3-4414-a8a1-57929b85285c@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Thu, 28 Nov 2024 08:50:32 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1654507.1733162761.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 02 Dec 2024 13:06:01 -0500
Message-ID: <1654508.1733162761@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1654508.1733162761%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> Committed, thanks.

Now that we have a more-or-less full set of buildfarm results
on this, I checked for new warnings, and found two:

pg_shmem.c: In function 'PGSharedMemoryIsInUse':
pg_shmem.c:323:33: warning: passing argument 1 of 'shmdt' from incompatibl=
e pointer type [-Wincompatible-pointer-types]
  323 |         if (memAddress && shmdt(memAddress) < 0)
      |                                 ^~~~~~~~~~
      |                                 |
      |                                 PGShmemHeader *
In file included from pg_shmem.c:27:
/usr/include/sys/shm.h:131:11: note: expected 'char *' but argument is of =
type 'PGShmemHeader *'
  131 | int shmdt(char *);
      |           ^~~~~~
pg_shmem.c: In function 'PGSharedMemoryCreate':
pg_shmem.c:838:37: warning: passing argument 1 of 'shmdt' from incompatibl=
e pointer type [-Wincompatible-pointer-types]
  838 |                 if (oldhdr && shmdt(oldhdr) < 0)
      |                                     ^~~~~~
      |                                     |
      |                                     PGShmemHeader *
/usr/include/sys/shm.h:131:11: note: expected 'char *' but argument is of =
type 'PGShmemHeader *'
  131 | int shmdt(char *);
      |           ^~~~~~

This is from hake[1], which is running OpenIndiana/illumos.
That platform shows a couple of other strange warnings, so maybe
re-eliminating these two is not worth worrying about, but
nonetheless the casts to void * were doing something here.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dhake&d=
t=3D2024-12-02%2017%3A19%3A40&stg=3Dmake