public inbox for [email protected]  
help / color / mirror / Atom feed
From: Cary Huang <[email protected]>
To: [email protected]
Cc: Bharath Rupireddy <[email protected]>
Subject: Re: Add last failed connection error message to pg_stat_wal_receiver
Date: Fri, 22 Jul 2022 20:58:08 +0000
Message-ID: <165852348876.1168.5615622255167011778.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CALj2ACWt6wkFnu7sac3pUb4WLZ3jA1m3cu7FJE3EovpGKzhwKw@mail.gmail.com>
References: <CALj2ACWt6wkFnu7sac3pUb4WLZ3jA1m3cu7FJE3EovpGKzhwKw@mail.gmail.com>
	<CALj2ACWt6wkFnu7sac3pUb4WLZ3jA1m3cu7FJE3EovpGKzhwKw@mail.gmail.com>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hello

The patch can be applied to PG master branch without problem and it passed regression and tap tests. I manually tested this feature too and the last conn error is correctly shown in the pg_stat_get_wal_receiver output, which does exactly as described. I think this feature is nice to have to troubleshoot replication issues on the standby side.

thank you

Cary Huang
----------------
Highgo Software Canada

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add last failed connection error message to pg_stat_wal_receiver
  In-Reply-To: <165852348876.1168.5615622255167011778.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox