From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove useless casts to (void *)
In-reply-to: <461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org>
References: <461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Tue, 29 Oct 2024 09:06:32 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <166212.1730211603.1@sss.pgh.pa.us>
Date: Tue, 29 Oct 2024 10:20:03 -0400
Message-ID: <166213.1730211603@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/166213.1730211603%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> There are a bunch of (void *) casts in the code that don't make sense to 
> me.  I think some of these were once necessary because char * was used 
> in place of void * for some function arguments.  And some of these were 
> probably just copied around without further thought.  I went through and 
> cleaned up most of these.  I didn't find any redeeming value in these. 
> They are just liable to hide actual problems such as incompatible types. 
>   But maybe there are other opinions.

I don't recall details, but I'm fairly sure some of these prevented
compiler warnings on some (old?) compilers.  Hard to be sure if said
compilers are all gone.

Looking at the sheer size of the patch, I'm kind of -0.1, just
because I'm afraid it's going to create back-patching gotchas.
I don't really find that it's improving readability, though
clearly that's a matter of opinion.

			regards, tom lane