From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-hackers@postgresql.org
Subject: Re: Augment every test postgresql.conf
In-reply-to: <20181230024014.GA181668@gust.leadboat.com>
References: <20181229021950.GA3302966@rfd.leadboat.com>
 <20181230024014.GA181668@gust.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 29 Dec 2018 21:40:14 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16622.1546141591.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 29 Dec 2018 22:46:31 -0500
Message-ID: <16623.1546141591@sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> Looking more closely, we already have the TEMP_CONFIG variable and apply=
 it to
> everything except TAP suites.  Closing that gap, as attached, is enough.=
  The
> buildfarm client uses TEMP_CONFIG to implement its extra_config setting,=
 so
> this will cause extra_config to start applying to TAP suites.

Seems reasonable, but it might be a good idea to warn the buildfarm-owners
list before committing.  (Although I guess it wouldn't be hard to check
the buildfarm database to see if anyone is putting anything interesting
into their critters' TEMP_CONFIG.)

Also, if we're to do this, it seems like applying it to back branches
would be helpful --- but will it work in all the back branches?

			regards, tom lane