From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
In-reply-to: <20220712173352.trdeq66asbv6vf2q@awork3.anarazel.de>
References: 
 <CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com>
 <CA+Tgmoazusui5EoU_7Z=AgwC5pTAqDndTa7d-owjvQwG3zoRhg@mail.gmail.com>
 <CA+hUKGLLJUMDgCzOK5K4NE6PpU87Ka7t7RQsZoZAZ_EKfL5L+A@mail.gmail.com>
 <CA+Tgmoaw6VBC9Xzr4vOaC0kc-94jb9nzH8MY38Gqn7=wy=i_3w@mail.gmail.com>
 <20220712173352.trdeq66asbv6vf2q@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 12 Jul 2022 10:33:52 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1662558.1657648462.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 12 Jul 2022 13:54:22 -0400
Message-ID: <1662559.1657648462@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1662559.1657648462%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Redefining functions, be it by linking in something or by redefining fun=
ction
> names via macros, is a mess. There's places where we then have to undefi=
ne
> some of these things to be able to include external headers etc. Some
> functions are only replaced in backends, others in frontend too. It make=
s it
> hard to know what exactly the assumed set of platform primitives is. Etc=
.

In the cases at hand, we aren't doing that, are we?  The replacement
function is only used on platforms that lack the relevant POSIX function,
so it's hard to argue that we're replacing anything.

			regards, tom lane