To: Alvaro Herrera <alvherre@commandprompt.com>
cc: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>,
	"Joshua D. Drake" <jd@commandprompt.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: libedit broke in head 
In-reply-to: <20060930200255.GC20466@alvh.no-ip.org> 
References: <451EB194.9090506@commandprompt.com>
	<15712.1159642857@sss.pgh.pa.us>
	<451EC216.8060104@kaltenbrunner.cc>
	<20060930200255.GC20466@alvh.no-ip.org>
Comments: In-reply-to Alvaro Herrera <alvherre@commandprompt.com>
	message dated "Sat, 30 Sep 2006 16:02:56 -0400"
Date: Sat, 30 Sep 2006 16:36:56 -0400
Message-ID: <16636.1159648616@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Alvaro Herrera <alvherre@commandprompt.com> writes:
> I think the switches are confusing ... when you are using libedit, you
> certainly don't want readline as well, so it seems natural to disable
> it.  I understand that what --without-readline really does is turn the
> line-editing capability off in general rather than just readline, which
> is confusing.

The documentation could be improved perhaps:

$ ./configure --help | grep -i edit    
  --with-libedit-preferred  prefer BSD Libedit over GNU Readline
  --without-readline      do not use GNU Readline / BSD Libedit line editing
$

ISTM the second line would be clearer if it read

  --without-readline      do not use GNU Readline nor BSD Libedit for editing

Also, we probably ought to see if we can make the libedit-preferred line
come out second.

			regards, tom lane