Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1uR-0008U2-3y for pgsql-hackers@arkaria.postgresql.org; Wed, 26 May 2021 22:21:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lm1uP-0004OF-Lk for pgsql-hackers@arkaria.postgresql.org; Wed, 26 May 2021 22:21:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1uP-0004O7-E0 for pgsql-hackers@lists.postgresql.org; Wed, 26 May 2021 22:21:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1uN-0003as-De for pgsql-hackers@postgresql.org; Wed, 26 May 2021 22:21:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 14QMLhLV1666833; Wed, 26 May 2021 18:21:43 -0400 From: Tom Lane To: Alvaro Herrera cc: Robert Haas , Michael Paquier , Justin Pryzby , Andres Freund , pgsql-hackers@postgresql.org, Dilip Kumar Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size? In-reply-to: <202105262208.iwm6dxqv2puy@alvherre.pgsql> References: <202105262208.iwm6dxqv2puy@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Wed, 26 May 2021 18:08:20 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1666831.1622067703.1@sss.pgh.pa.us> Date: Wed, 26 May 2021 18:21:43 -0400 Message-ID: <1666832.1622067703@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > Looks good to me. > I tested the behavior with partitioned tables and it seems OK. Thanks for reviewing/testing! > It would be good to have a test case in src/bin/pg_dump/t/002_pg_dump.pl > for the case Personally I won't touch 002_pg_dump.pl with a 10-foot pole, but if somebody else wants to, have at it. > ... and I find it odd that we don't seem to have anything > for the "CREATE TABLE foo (LIKE sometab INCLUDING stuff)" form of the > command ... but neither of those seem the fault of this patch, and they > both work as [I think] is intended. Hm, there's this in compression.sql: -- test LIKE INCLUDING COMPRESSION CREATE TABLE cmdata2 (LIKE cmdata1 INCLUDING COMPRESSION); \d+ cmdata2 Or did you mean the case with a partitioned table specifically? regards, tom lane