Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr660-0000qi-Cb for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Sep 2017 17:32:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dr65z-0005wy-MB for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Sep 2017 17:32:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dr65y-0005vg-DW for pgsql-hackers@postgresql.org; Sun, 10 Sep 2017 17:32:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dr65r-00018h-Dk for pgsql-hackers@postgresql.org; Sun, 10 Sep 2017 17:32:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v8AHWME3016675; Sun, 10 Sep 2017 13:32:22 -0400 From: Tom Lane To: Victor Drobny cc: Thomas Munro , Aleksander Alekseev , Pgsql Hackers Subject: Re: Red-Black tree traversal tests In-reply-to: <17021.1505002020@sss.pgh.pa.us> References: <20170801095446.GA22764@e733.localdomain> <20170801095835.GB22764@e733.localdomain> <2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru> <419a79bae64398144716c38b85359539@postgrespro.ru> <20170803084222.GA14690@e733.localdomain> <2479.1504737491@sss.pgh.pa.us> <17021.1505002020@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Sat, 09 Sep 2017 20:07:00 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16673.1505064742.1@sss.pgh.pa.us> Date: Sun, 10 Sep 2017 13:32:22 -0400 Message-ID: <16674.1505064742@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org I wrote: > In the meantime, here's my version. Notable changes: I went ahead and pushed this, with the removal of the preorder/postorder code, so we can see if the buildfarm finds out anything interesting. Feel free to continue to submit improvements though. One thing that occurred to me is that as-is, this is entirely black-box testing. It doesn't try to check that the tree actually satisfies the RB invariants, which is something that is interesting for performance reasons. (That is, the code could pass these tests even though it produces an unbalanced tree with horrible performance.) Is it worth adding logic for that? Not sure. It's not like we are actively changing the RB code or have reason to think it is buggy. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers