pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Python 3.11 vs. Postgres 3+ messages / 2 participants [nested] [flat]
Commits from this thread: 2021-11-25 99e4d24a9d 1cc13b83eb 04875ae92f 0d335cbd5c a83b1bab0b 4339e10f09 Remove unneeded Python includes
* Python 3.11 vs. Postgres @ 2021-11-24 03:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 3+ messages in thread From: Tom Lane @ 2021-11-24 03:07 UTC (permalink / raw) To: pgsql-hackers@lists.postgresql.org According to [1], we need to stop including Python's <eval.h>. I've not checked whether this creates any backwards-compatibility issues. regards, tom lane [1] https://bugzilla.redhat.com/show_bug.cgi?id=2023272 ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Python 3.11 vs. Postgres @ 2021-11-24 07:24 Peter Eisentraut <peter.eisentraut@enterprisedb.com> parent: Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 3+ messages in thread From: Peter Eisentraut @ 2021-11-24 07:24 UTC (permalink / raw) To: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-hackers@lists.postgresql.org On 24.11.21 04:07, Tom Lane wrote: > According to [1], we need to stop including Python's <eval.h>. > I've not checked whether this creates any backwards-compatibility > issues. > > regards, tom lane > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=2023272 See attached patch. The minimum Python version for this change is 2.4, which is the oldest version supported by PG10, so we can backpatch this to all live branches. Attachments:^ permalink raw reply [nested|flat] 3+ messages in thread0001-Remove-unneeded-Python-includes.patch (text/plain, 893B) download
From 069c0ee626aa7cabe3098feec97dd161f8c81376 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut <peter@eisentraut.org> Date: Wed, 10 Nov 2021 09:48:18 +0100 Subject: [PATCH] Remove unneeded Python includes Inluding <compile.h> and <eval.h> has not been necessary since Python 2.4, since they are included via <Python.h>. Morever, <eval.h> is being removed in Python 3.11. So remove these includes. --- src/pl/plpython/plpython.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/pl/plpython/plpython.h b/src/pl/plpython/plpython.h index 994457b37d..ae1275afe2 100644 --- a/src/pl/plpython/plpython.h +++ b/src/pl/plpython/plpython.h @@ -94,9 +94,6 @@ #undef TEXTDOMAIN #define TEXTDOMAIN PG_TEXTDOMAIN("plpython") -#include <compile.h> -#include <eval.h> - /* put back our *printf macros ... this must match src/include/port.h */ #ifdef vsnprintf #undef vsnprintf -- 2.33.1
* Re: Python 3.11 vs. Postgres @ 2021-11-24 17:39 Tom Lane <tgl@sss.pgh.pa.us> parent: Peter Eisentraut <peter.eisentraut@enterprisedb.com> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2021-11-24 17:39 UTC (permalink / raw) To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; +Cc: pgsql-hackers@lists.postgresql.org Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes: > On 24.11.21 04:07, Tom Lane wrote: >> According to [1], we need to stop including Python's <eval.h>. > See attached patch. The minimum Python version for this change is 2.4, > which is the oldest version supported by PG10, so we can backpatch this > to all live branches. LGTM. Tested with v10 and prairiedog's Python 2.4.1. regards, tom lane ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-11-24 17:39 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-24 03:07 Python 3.11 vs. Postgres Tom Lane <tgl@sss.pgh.pa.us> 2021-11-24 07:24 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com> 2021-11-24 17:39 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox