Re: [PATCH] Support % wildcard in extension upgrade filenames

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Regina Obe <[email protected]>
To: [email protected]
Cc: Sandro Santilli <[email protected]>
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Date: Tue, 22 Nov 2022 19:03:14 +0000
Message-ID: <166914379479.1121.7549798686571352890.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <20221117095734.igldlk6kngr6ogim@c19>
References: <YgakFklJyM5pNdt+@c19>
	<20221117095734.igldlk6kngr6ogim@c19>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

I reviewed this patch https://www.postgresql.org/message-id/20221117095734.igldlk6kngr6ogim%40c19

Most look good to me.  The only things that have changed since last I reviewed this, with the new patch is

1) wildcard_upgrades=true is no longer needed in the control file and will break if present.  This is an expected change, since we are now going strictly by presence of % extension upgrade scripts per suggestions
2) The meson build issue has been fixed.  Cirrus is passing on that now.  I'm still fiddling with my meson setup, so didn't personally test this.

3) The documentation has been updated to no longer include wildcard_upgrades as a variable for control file.

and has this text now describing it's use:

 The literal value % can be used as the old_version component in an extension update script for it to match any version. Such wildcard update scripts will only be used when no explicit path is found from old to target version.

Given that a suitable update script is available, the command ALTER EXTENSION UPDATE will update an installed extension to the specified new version. The update script is run in the same environment that CREATE EXTENSION provides for installation scripts: in particular, search_path is set up in the same way, and any new objects created by the script are automatically added to the extension. Also, if the script chooses to drop extension member objects, they are automatically dissociated from the extension. 

I built the html docs but ran into a lot of warnings I don't recall getting last time.  I think this is just my doc local setup is a bit messed up or something else changed in the doc setup.

My main gripe with this patch is Sandro did not increment the version number of it, so it's the same name as an old patch he had submitted before.

view thread (24+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
  In-Reply-To: <166914379479.1121.7549798686571352890.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox