Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhzbw-0004q8-SM for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Nov 2021 19:38:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mhzbv-0004uH-HM for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Nov 2021 19:38:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhzbv-0004u7-8p for pgsql-hackers@lists.postgresql.org; Tue, 02 Nov 2021 19:38:19 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhzbs-0001S1-0j for pgsql-hackers@lists.postgresql.org; Tue, 02 Nov 2021 19:38:18 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1A2Jc1P61669192; Tue, 2 Nov 2021 15:38:01 -0400 From: Tom Lane To: Alvaro Herrera cc: Andres Freund , Andrew Dunstan , "Bossart, Nathan" , Kyotaro Horiguchi , "masao.fujii@oss.nttdata.com" , "pgsql-hackers@lists.postgresql.org" , "mengjuan.cmj@alibaba-inc.com" , "Jakub.Wartak@tomtom.com" , Ryo Matsumura Subject: Re: prevent immature WAL streaming In-reply-to: <202110132209.uyw4ubpc2ztc@alvherre.pgsql> References: <202110132209.uyw4ubpc2ztc@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Wed, 13 Oct 2021 19:09:28 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1669190.1635881881.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 02 Nov 2021 15:38:01 -0400 Message-ID: <1669191.1635881881@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > On 2021-Oct-13, Andres Freund wrote: >> Yea, let's go for your patch then. I've verified that at least locally = it >> passes under valgrind. > Ah great, thanks. Pushed then. Seems like this hasn't fixed the problem: skink still fails on this test occasionally. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dskink&dt=3D2021-= 10-22%2013%3A52%3A00 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dskink&dt=3D2021-= 11-02%2000%3A28%3A30 Both of these look like # Failed test '000000010000000000000002 differs from 0000000100000000000= 00002' # at t/026_overwrite_contrecord.pl line 61. # Looks like you failed 1 test of 3. t/026_overwrite_contrecord.pl ........ = Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests = which looks like the same thing we were seeing before. 010e52337 seems to have just decreased the probability of failure. regards, tom lane