Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pM4nH-0003ll-7n
	for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Jan 2023 10:20:15 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pM4nF-00029r-Lf
	for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Jan 2023 10:20:13 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <youzhick@gmail.com>)
	id 1pM4nF-00029i-Ba
	for pgsql-hackers@lists.postgresql.org; Sun, 29 Jan 2023 10:20:13 +0000
Received: from mahout.postgresql.org ([2001:4800:3e1:1::227])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <youzhick@gmail.com>)
	id 1pM4n8-00029g-Qw
	for pgsql-hackers@lists.postgresql.org; Sun, 29 Jan 2023 10:20:12 +0000
Received: from coridan.postgresql.org ([2001:4800:3e1:1::213])
	by mahout.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <youzhick@gmail.com>)
	id 1pM4n6-00035U-Hl
	for pgsql-hackers@lists.postgresql.org; Sun, 29 Jan 2023 10:20:04 +0000
Received: from localhost ([127.0.0.1] helo=coridan.postgresql.org)
	by coridan.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <youzhick@gmail.com>)
	id 1pM4n5-0015av-8S
	for pgsql-hackers@lists.postgresql.org; Sun, 29 Jan 2023 10:20:03 +0000
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
To: pgsql-hackers@lists.postgresql.org
From: Mikhail Gribkov <youzhick@gmail.com>
Cc: Christoph Heiss <christoph@c8h4.io>
Date: Sun, 29 Jan 2023 10:19:12 +0000
User-Agent: pgcommitfest
X-cfsender: youzhick
In-Reply-To: <CA+hUKGLiY1e+1=pB7hXJOyGj1dJOfgde+HmiSnv3gDKayUFJMA@mail.gmail.com>
References: <a2075c5a-66f9-a564-f038-9ac044b03117@c8h4.io> <CA+hUKGLiY1e+1=pB7hXJOyGj1dJOfgde+HmiSnv3gDKayUFJMA@mail.gmail.com>
Message-ID: <167498755212.1114.17909291598039410948.pgcf@coridan.postgresql.org>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/167498755212.1114.17909291598039410948.pgcf%40coridan.postgresql.org>
Precedence: bulk

VGhlIGZvbGxvd2luZyByZXZpZXcgaGFzIGJlZW4gcG9zdGVkIHRocm91Z2ggdGhlIGNvbW1pdGZl
c3QgYXBwbGljYXRpb246Cm1ha2UgaW5zdGFsbGNoZWNrLXdvcmxkOiAgdGVzdGVkLCBwYXNzZWQK
SW1wbGVtZW50cyBmZWF0dXJlOiAgICAgICB0ZXN0ZWQsIHBhc3NlZApTcGVjIGNvbXBsaWFudDog
ICAgICAgICAgIHRlc3RlZCwgZmFpbGVkCkRvY3VtZW50YXRpb246ICAgICAgICAgICAgdGVzdGVk
LCBwYXNzZWQKCkhpIENocmlzdG9waCwNCg0KVGhlIHBhdGNoIGhhdmUgYSBwb3RlbnRpYWwsIGFs
dGhvdWdoIEkgaGF2ZSB0byBhZ3JlZSB3aXRoIEppbSBKb25lcywgaXQgb2J2aW91c2x5IGhhdmUg
YSBwcm9ibGVtIHdpdGggImFsdGVyIHZpZXcgPG5hbWU+IHNldDx0YWI+IiBoYW5kbGluZy4NCg0K
Rmlyc3Qgb2YgYWxsIHVzZXIgY2FuIG5vdGljZSwgdGhhdCBTRVQgYW5kIFJFU0VUIGFsdGVybmF0
aXZlcyBhcmUgcHJvcG9zZWQgaW4gYW4gYWJzb2x1dGVseSBlcXVpdmFsZW50IHdheToNCnBvc3Rn
cmVzPSMgYWx0ZXIgdmlldyBWVlYgPHRhYj4NCkFMVEVSIENPTFVNTiAgT1dORVIgVE8gICAgICBS
RU5BTUUgICAgICAgIFJFU0VUICggICAgICAgU0VUICggICAgICAgICBTRVQgU0NIRU1BDQoNCkJ1
dCBjb21wbGV0aW9uIG9mIGEgcGFyZW50aGVzZXMgZGlmZmVycyBmb3JlIHRoZXNlIGFsdGVybmF0
aXZlczoNCg0KcG9zdGdyZXM9IyBhbHRlciB2aWV3IFZWViByZXNldDx0YWI+IC0+IGNvbXBsZXRl
cyB3aXRoICI8c3BhY2U+KCIgLT4gPHRhYj4NCkNIRUNLX09QVElPTiAgICAgIFNFQ1VSSVRZX0JB
UlJJRVIgIFNFQ1VSSVRZX0lOVk9LRVINCg0KcG9zdGdyZXM9IyBhbHRlciB2aWV3IFZWViBzZXQ8
dGFiPiAtPiBjb21wbGV0ZXMgd2l0aCBhIHNpbmdsZSBzcGFzZSAtPiA8dGFiPg0KRGlzcGxheSBh
bGwgMTg4IHBvc3NpYmlsaXRpZXM/ICh5IG9yIG4pDQooYW5kIHRoZXNlIDE4OCBwb3NzaWJpbGl0
aWVzIGRvIG5vdCBjb250YWluICIoIikNCg0KVGhlIHByb2JtZW4gaXMgb2J2aW91c2x5IGluIHRo
ZSBuZXdseSBhZGRlZCBzZWNvbmQgbGluZSBvZiB0aGUgZm9sbG93aW5nIGNsYXVzZToNCgkJQ09N
UExFVEVfV0lUSCgiQUxURVIgQ09MVU1OIiwgIk9XTkVSIFRPIiwgIlJFTkFNRSIsDQoJCQkJCSAg
IlNFVCBTQ0hFTUEiLCAiU0VUICgiLCAiUkVTRVQgKCIpOw0KDQoic2V0IHNjaGVtYSIgYW5kICJz
ZXQgKCIgYWx0ZXJuYXRpdmVzIGFyZSBjb21wZXRpbmcsIHdoaWxlIGNvbXBsZXRpb24gb2YgdGhl
IGNvbW1vbiBwYXJ0ICJzZXQ8c3BhY2U+IiBsZWFkcyB0byBhIHN0cmluZyBjb21wb3NpdGlvbiB3
aGljaCBkb2VzIG5vdCBoYXZlIHRoZSBjaGVjayBicmFuY2ggKE1hdGNoZXMoIkFMVEVSIiwgIlZJ
RVciLCBNYXRjaEFueSwgIlNFVCIpKS4NCg0KSSB0aGluayBpdCBtYXkgd29ydGggbG9va2luZyBh
dCAiYWx0ZXIgbWF0ZXJpYWxpemVkIHZpZXciICBjb21wbGV0aW9uIHRyZWUgYW5kIG1ha2luZyAi
YWx0ZXIgdmlldyIgdGhlIHNhbWUgd2F5LgoKVGhlIG5ldyBzdGF0dXMgb2YgdGhpcyBwYXRjaCBp
czogV2FpdGluZyBvbiBBdXRob3IK