From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>,
 Dilip Kumar <dilipbalaut@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced
 size?
In-reply-to: <20210527003144.xxqppojoiwurc2iz@alap3.anarazel.de>
References: <20210517212857.qyk4fxykfbxhmxof@alap3.anarazel.de>
 <YKMXVHCoNGZ61E9q@paquier.xyz> <YKdT5ZM5OInCsDkM@paquier.xyz>
 <3962395.1621609263@sss.pgh.pa.us>
 <20210521211929.pcehg6f23icwstdb@alap3.anarazel.de>
 <YKsm7qkz+Cq3C3mr@paquier.xyz>
 <CAFiTN-uLQCRLatapZhEaNGH9njY=LndyXJux7H9YCfT9RcE7gA@mail.gmail.com>
 <YKtpZI4PBpVG3ryH@paquier.xyz>
 <CAFiTN-vpHrCzdeyKxpoPViyJCZZx-h8KghQJFyxZd7+Dys6Cow@mail.gmail.com>
 <YKyPM6UC+tBHEuxo@paquier.xyz>
 <20210527003144.xxqppojoiwurc2iz@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 26 May 2021 17:31:44 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1677690.1622075746.1@sss.pgh.pa.us>
Date: Wed, 26 May 2021 20:35:46 -0400
Message-ID: <1677691.1622075746@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1677691.1622075746%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> The efficiency bit is probably going to be swamped by the addition of
> the compression handling, given the amount of additional work we're now
> doing in in reform_and_rewrite_tuple().

Only if the user has explicitly requested a change of compression, no?

			regards, tom lane