From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
cc: solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>,
        Aleksander Alekseev <aleksander@tigerdata.com>,
        Payal Singh <payals1@umbc.edu>, pgsql-hackers@lists.postgresql.org
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline
 comments
In-reply-to: 
 <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>
References: <EB0141C5-ACC2-4F0B-85EA-0E3AFBCE322F@umbc.edu>
 <CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com>
 <1645542.1778456249@sss.pgh.pa.us>
 <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>
Comments: In-reply-to John Naylor <johncnaylorls@gmail.com>
	message dated "Mon, 11 May 2026 11:46:06 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1678068.1778475894.1@sss.pgh.pa.us>
Date: Mon, 11 May 2026 01:04:54 -0400
Message-ID: <1678069.1778475894@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1678069.1778475894%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <johncnaylorls@gmail.com> writes:
> On Mon, May 11, 2026 at 6:37 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think those are pretty much all improvements, except that it kind
>> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

> Agreed, although this one now seems to use even more vertical space
> that doesn't contain anything:

> -/* Function works as follows:
> +/*
> + * Function works as follows:
> + *
>   *
>   *
> - * */
> + */

Yeah ... what's actually happening there is that it's replacing

 * */

with

 *
 */

although the diff misattributes the extra line.  There are few
enough of those that I didn't think it was worth getting
excited about ...

			regards, tom lane