public inbox for [email protected]  

help / color / mirror / Atom feed

From: Cary Huang <[email protected]>
To: [email protected]
Cc: Hannu Krosing <[email protected]>
Subject: Re: pgbench - adding pl/pgsql versions of tests
Date: Fri, 24 Mar 2023 22:17:33 +0000
Message-ID: <167969625359.628976.7987246419855702878.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <[email protected]>
References: <CAMT0RQR1TNSnSWwd65is=HCDjiP4i25mcDDoctEBEiV8351cMQ@mail.gmail.com>
	<[email protected]>

The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hi

thank you for the patch. It can be applied to current master branch and compiled fine. 

The feature works as described, I am able to run plpgsql-tpcb-like and plpgsql-simple-update scripts as you have added them.

But I am not sure the purpose of --no-function to prevent the creation of pl/pgsql functions when the new plpgsql test scripts need them. 

I initialized pgbench database with --no-function, and plpgsql-tpcb-like and plpgsql-simple-update scripts will fail to run

thanks

Cary Huang
===============
Highgo Software Canada
www.highgo.ca

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgbench - adding pl/pgsql versions of tests
  In-Reply-To: <167969625359.628976.7987246419855702878.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox