From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgreSQL.org
Subject: Protection lost in expression eval changeover
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16802.1490723570.1@sss.pgh.pa.us>
Date: Tue, 28 Mar 2017 13:52:50 -0400
Message-ID: <16803.1490723570@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

CheckVarSlotCompatibility contains the comment

	 * Note: we allow a reference to a dropped attribute.  slot_getattr will
	 * force a NULL result in such cases.

While still true, that second sentence is now quite irrelevant, because we
don't go through slot_getattr anymore.  So it seems like we are missing
some needed protection.  I'm inclined to think that it'd be all right to
just throw an error immediately in CheckVarSlotCompatibility if the
target column is dropped.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers