From: Tom Lane <tgl@sss.pgh.pa.us>
To: Teodor Sigaev <teodor@sigaev.ru>
cc: Peter Eisentraut <peter_e@gmx.net>,
        Eugene Kazakov <e.kazakov@postgrespro.ru>,
        pgsql-hackers@postgresql.org
Subject: Re: Small PATCH: check of 2 Perl modules
In-reply-to: <56C1D959.7030105@sigaev.ru>
References: <56BDDC20.9020506@postgrespro.ru> <56C1D3D3.7010001@gmx.net>
 <56C1D959.7030105@sigaev.ru>
Comments: In-reply-to Teodor Sigaev <teodor@sigaev.ru>
	message dated "Mon, 15 Feb 2016 16:57:45 +0300"
Date: Mon, 15 Feb 2016 10:02:12 -0500
Message-ID: <16821.1455548532@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Teodor Sigaev <teodor@sigaev.ru> writes:
>> On 2/12/16 8:20 AM, Eugene Kazakov wrote:
>>> TAP-tests need two Perl modules: Test::More and IPC::Run.

>> I think those modules are part of a standard Perl installation.

> IPC::Run is not. At least for perl from ports tree in FreeBSD.

Yeah, I remember having had to install IPC::Run from CPAN, and a couple
of other things too (but I don't remember Test::More specifically), when
setting up some of my buildfarm critters.  It's likely that a lot of
distros bundle these, but I don't think IPC::Run is in a basic
built-from-source Perl.

The real question though is do we need a configure check at all.

Given that investigation into a CMake conversion is actively going
on, I'm hesitant to move the goalposts for it by introducing a brand
new type of configure check.  Maybe we should punt this issue until
that patch is either accepted or decisively rejected.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers