Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCXCJ-0004x2-U5 for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jan 2023 02:38:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pCXCI-0003QD-MF for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jan 2023 02:38:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCXCI-0003Q3-D1 for pgsql-hackers@lists.postgresql.org; Tue, 03 Jan 2023 02:38:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCXCE-00061c-Tz for pgsql-hackers@postgresql.org; Tue, 03 Jan 2023 02:38:38 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3032cSOD1682144; Mon, 2 Jan 2023 21:38:28 -0500 From: Tom Lane To: Michael Paquier cc: Justin Pryzby , Paul Ramsey , pgsql-hackers@postgresql.org Subject: Re: [PATCH] random_normal function In-reply-to: References: <20221208224623.GQ27893@telsasoft.com> <20221231035804.GJ1153@telsasoft.com> Comments: In-reply-to Michael Paquier message dated "Tue, 03 Jan 2023 11:24:38 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <1682142.1672713508.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Mon, 02 Jan 2023 21:38:28 -0500 Message-ID: <1682143.1672713508@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > FYI, here is the failure: > [21:23:10.814] In file included from pg_prng.c:27: > [21:23:10.814] ../../src/include/utils/float.h:46:16: error: ‘struct > Node’ declared inside parameter list will not be visible outside of > this definition or declaration [-Werror] > [21:23:10.814] 46 | struct Node *escontext); Hmm ... this looks an awful lot like it is the fault of ccff2d20e not of the random_normal patch; that is, we probably need a "struct Node" stub declaration in float.h. However, why are we not seeing any reports of this from elsewhere? I'm concerned now that there are more places also needing stub declarations, but my test process didn't expose it. regards, tom lane