Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecBch-0000dQ-OZ for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 14:56:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecBcg-0003ZY-VZ for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 14:56:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ecBcg-0003ZN-LY for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2018 14:56:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ecBcd-0005fX-QS for pgsql-hackers@postgresql.org; Thu, 18 Jan 2018 14:56:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0IEum5T016823; Thu, 18 Jan 2018 09:56:48 -0500 From: Tom Lane To: Marina Polyakova cc: vitus@wagner.pp.ru, Andres Freund , pgsql-hackers@postgresql.org, Alvaro Herrera Subject: Re: master make check fails on Solaris 10 In-reply-to: <0e183c12a68af526ebc03c5c26206c44@postgrespro.ru> References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru> <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de> <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru> <1232.1515780057@sss.pgh.pa.us> <15299.1515867055@sss.pgh.pa.us> <18209.1516059711@sss.pgh.pa.us> <90ab676392c8f9c84431976147097cf0@postgrespro.ru> <17897.1516202926@sss.pgh.pa.us> <1c70bab595a37ffa3a7fafea29fa6f55@postgrespro.ru> <31743.1516206789@sss.pgh.pa.us> <0e183c12a68af526ebc03c5c26206c44@postgrespro.ru> Comments: In-reply-to Marina Polyakova message dated "Thu, 18 Jan 2018 12:53:19 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16821.1516287408.1@sss.pgh.pa.us> Date: Thu, 18 Jan 2018 09:56:48 -0500 Message-ID: <16822.1516287408@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Marina Polyakova writes: > Applying your patch on commit f033462d8f77c40b7d6b33c5116e50118fb4699d > and using the configuration command from [1], I got: > checking for __int128... yes > checking for __int128 alignment bug... broken > ... > And make check-world passes. Victor said that he used a much simpler > configuration command, and I'm trying to figure out what's changed.. Weird. Maybe the gcc bug only manifests with certain optimization flags? That's not what I'd have expected from Victor's theory about why the code is wrong, but if it only shows up some of the time, it's hard to think of another explanation. > P.S. I found the trailing whitespace in line 80: > ! int128a q; Ah, thanks. Probably git would've whined about that when I went to commit, but it's good to catch sooner. regards, tom lane