public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tristen Raab <[email protected]>
To: [email protected]
Cc: Sami Imseih <[email protected]>
Subject: Re: Correct the documentation for work_mem
Date: Mon, 31 Jul 2023 20:44:21 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvpTRix7P7j2UdwhCEH0cSN7EwJT++Oa6k3UV0QjnwskVg@mail.gmail.com>
References: <[email protected]>
	<CAApHDvpTRix7P7j2UdwhCEH0cSN7EwJT++Oa6k3UV0QjnwskVg@mail.gmail.com>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            tested, passed

Hello,

I've reviewed and built the documentation for the updated patch. As it stands right now I think the documentation for this section is quite clear.

> I'm wondering about adding "and more than one of these operations may
> be in progress simultaneously".  Are you talking about concurrent
> sessions running other queries which are using work_mem too?

This appears to be referring to the "sort and hash" operations mentioned prior.

> If so,
> isn't that already covered by the final sentence in the quoted text
> above? if not, what is running simultaneously?

I believe the last sentence is referring to another session that is running its own sort and hash operations. So the first section you mention is describing how sort and hash operations can be in execution at the same time for a query, while the second refers to how sessions may overlap in their execution of sort and hash operations if I am understanding this correctly.

I also agree that changing "sort or hash" to "sort and hash" is a better description.

Tristen

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Correct the documentation for work_mem
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox