Content-Type: multipart/mixed; boundary="------------A0SpDen9pWeU1w4ZeqEzZtj0"
Message-ID: <16989737-1aa8-48fd-8dfe-b7ada06509ab@technowledgy.de>
Date: Fri, 8 Nov 2024 20:08:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Wolfgang Walther <walther@technowledgy.de>
Content-Language: en-US
To: pgsql-hackers@lists.postgresql.org
Subject: Fix port/pg_iovec.h building extensions on x86_64-darwin
Archived-At: <https://www.postgresql.org/message-id/16989737-1aa8-48fd-8dfe-b7ada06509ab%40technowledgy.de>
Precedence: bulk

This is a multi-part message in MIME format.
--------------A0SpDen9pWeU1w4ZeqEzZtj0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we 
encounter the following build failure in nixpkgs:


/nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:71:12: 
error: comparison of integers of different signs: 'ssize_t' (aka 'long') 
and 'const size_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]
                 if (part < iov[i].iov_len)
                     ~~~~ ^ ~~~~~~~~~~~~~~
/nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:110:12: 
error: comparison of integers of different signs: 'ssize_t' (aka 'long') 
and 'const size_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]
                 if (part < iov[i].iov_len)
                     ~~~~ ^ ~~~~~~~~~~~~~~
2 errors generated.


The attached patch fixes those.

Hopefully this can make it into the minor release next week.

Best,

Wolfgang

[1]: https://hydra.nixos.org/build/276421287/nixlog/1
[2]: https://hydra.nixos.org/build/276419879/nixlog/1
--------------A0SpDen9pWeU1w4ZeqEzZtj0
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Fix-build-on-x86_64-darwin.patch"
Content-Disposition: attachment;
 filename="0001-Fix-build-on-x86_64-darwin.patch"
Content-Transfer-Encoding: base64

RnJvbSBjOTA2YjE4MmI1NTAzYzljZWViZjU4ZTI1ZTM0OTYxNTdjMjlkZWRiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBXb2xmZ2FuZyBXYWx0aGVyIDx3YWx0aGVyQHRlY2hu
b3dsZWRneS5kZT4KRGF0ZTogRnJpLCA4IE5vdiAyMDI0IDE5OjQxOjAwICswMTAwClN1Ympl
Y3Q6IFtQQVRDSF0gRml4IHBnX2Nyb24vcGdfaGxsIGJ1aWxkIG9uIHg4Nl82NC1kYXJ3aW4K
CkluIGZpbGUgaW5jbHVkZWQgZnJvbSBzcmMvaGxsLmM6Mjg6CkluIGZpbGUgaW5jbHVkZWQg
ZnJvbQovbml4L3N0b3JlLzI0cnd5dnNjOTBuaHd3NWRmZHAzN2N3cTRjMXZ5Y2dpLXBvc3Rn
cmVzcWwtaml0LTE3LjAtZGV2L2luY2x1ZGUvc2VydmVyL2Z1bmNhcGkuaDoyMToKSW4gZmls
ZSBpbmNsdWRlZCBmcm9tCi9uaXgvc3RvcmUvMjRyd3l2c2M5MG5od3c1ZGZkcDM3Y3dxNGMx
dnljZ2ktcG9zdGdyZXNxbC1qaXQtMTcuMC1kZXYvaW5jbHVkZS9zZXJ2ZXIvZXhlY3V0b3Iv
ZXhlY3V0b3IuaDoxNzoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tCi9uaXgvc3RvcmUvMjRyd3l2
c2M5MG5od3c1ZGZkcDM3Y3dxNGMxdnljZ2ktcG9zdGdyZXNxbC1qaXQtMTcuMC1kZXYvaW5j
bHVkZS9zZXJ2ZXIvZXhlY3V0b3IvZXhlY2Rlc2MuaDoxODoKSW4gZmlsZSBpbmNsdWRlZCBm
cm9tCi9uaXgvc3RvcmUvMjRyd3l2c2M5MG5od3c1ZGZkcDM3Y3dxNGMxdnljZ2ktcG9zdGdy
ZXNxbC1qaXQtMTcuMC1kZXYvaW5jbHVkZS9zZXJ2ZXIvbm9kZXMvZXhlY25vZGVzLmg6NDY6
CkluIGZpbGUgaW5jbHVkZWQgZnJvbQovbml4L3N0b3JlLzI0cnd5dnNjOTBuaHd3NWRmZHAz
N2N3cTRjMXZ5Y2dpLXBvc3RncmVzcWwtaml0LTE3LjAtZGV2L2luY2x1ZGUvc2VydmVyL3V0
aWxzL3NoYXJlZHR1cGxlc3RvcmUuaDoxNzoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tCi9uaXgv
c3RvcmUvMjRyd3l2c2M5MG5od3c1ZGZkcDM3Y3dxNGMxdnljZ2ktcG9zdGdyZXNxbC1qaXQt
MTcuMC1kZXYvaW5jbHVkZS9zZXJ2ZXIvc3RvcmFnZS9mZC5oOjQ2Ogovbml4L3N0b3JlLzI0
cnd5dnNjOTBuaHd3NWRmZHAzN2N3cTRjMXZ5Y2dpLXBvc3RncmVzcWwtaml0LTE3LjAtZGV2
L2luY2x1ZGUvc2VydmVyL3BvcnQvcGdfaW92ZWMuaDo3MToxMjoKZXJyb3I6IGNvbXBhcmlz
b24gb2YgaW50ZWdlcnMgb2YgZGlmZmVyZW50IHNpZ25zOiAnc3NpemVfdCcgKGFrYSAnbG9u
ZycpCmFuZCAnY29uc3Qgc2l6ZV90JyAoYWthICdjb25zdCB1bnNpZ25lZCBsb25nJykgWy1X
ZXJyb3IsLVdzaWduLWNvbXBhcmVdCiAgICAgICAgICAgICAgICBpZiAocGFydCA8IGlvdltp
XS5pb3ZfbGVuKQogICAgICAgICAgICAgICAgICAgIH5+fn4gXiB+fn5+fn5+fn5+fn5+fgov
bml4L3N0b3JlLzI0cnd5dnNjOTBuaHd3NWRmZHAzN2N3cTRjMXZ5Y2dpLXBvc3RncmVzcWwt
aml0LTE3LjAtZGV2L2luY2x1ZGUvc2VydmVyL3BvcnQvcGdfaW92ZWMuaDoxMTA6MTI6CmVy
cm9yOiBjb21wYXJpc29uIG9mIGludGVnZXJzIG9mIGRpZmZlcmVudCBzaWduczogJ3NzaXpl
X3QnIChha2EgJ2xvbmcnKQphbmQgJ2NvbnN0IHNpemVfdCcgKGFrYSAnY29uc3QgdW5zaWdu
ZWQgbG9uZycpIFstV2Vycm9yLC1Xc2lnbi1jb21wYXJlXQogICAgICAgICAgICAgICAgaWYg
KHBhcnQgPCBpb3ZbaV0uaW92X2xlbikKICAgICAgICAgICAgICAgICAgICB+fn5+IF4gfn5+
fn5+fn5+fn5+fn4KMiBlcnJvcnMgZ2VuZXJhdGVkLgotLS0KIHNyYy9pbmNsdWRlL3BvcnQv
cGdfaW92ZWMuaCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwg
MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9wb3J0L3BnX2lvdmVj
LmggYi9zcmMvaW5jbHVkZS9wb3J0L3BnX2lvdmVjLmgKaW5kZXggNzI1NWMxYmQ5MTEuLmU1
ZmU2NzdiMzcxIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9wb3J0L3BnX2lvdmVjLmgKKysr
IGIvc3JjL2luY2x1ZGUvcG9ydC9wZ19pb3ZlYy5oCkBAIC02OCw3ICs2OCw3IEBAIHBnX3By
ZWFkdihpbnQgZmQsIGNvbnN0IHN0cnVjdCBpb3ZlYyAqaW92LCBpbnQgaW92Y250LCBvZmZf
dCBvZmZzZXQpCiAJCX0KIAkJc3VtICs9IHBhcnQ7CiAJCW9mZnNldCArPSBwYXJ0OwotCQlp
ZiAocGFydCA8IGlvdltpXS5pb3ZfbGVuKQorCQlpZiAoKHNpemVfdCkgcGFydCA8IGlvdltp
XS5pb3ZfbGVuKQogCQkJcmV0dXJuIHN1bTsKIAl9CiAJcmV0dXJuIHN1bTsKQEAgLTEwNyw3
ICsxMDcsNyBAQCBwZ19wd3JpdGV2KGludCBmZCwgY29uc3Qgc3RydWN0IGlvdmVjICppb3Ys
IGludCBpb3ZjbnQsIG9mZl90IG9mZnNldCkKIAkJfQogCQlzdW0gKz0gcGFydDsKIAkJb2Zm
c2V0ICs9IHBhcnQ7Ci0JCWlmIChwYXJ0IDwgaW92W2ldLmlvdl9sZW4pCisJCWlmICgoc2l6
ZV90KSBwYXJ0IDwgaW92W2ldLmlvdl9sZW4pCiAJCQlyZXR1cm4gc3VtOwogCX0KIAlyZXR1
cm4gc3VtOwotLSAKMi40Ny4wCgo=

--------------A0SpDen9pWeU1w4ZeqEzZtj0--