Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkGkK-00CukC-09 for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jan 2026 07:10:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vkGkI-006bqL-2t for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jan 2026 07:10:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkGkI-006bqD-1a for pgsql-hackers@lists.postgresql.org; Mon, 26 Jan 2026 07:10:46 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vkGkG-00000000V6e-1cKz for pgsql-hackers@lists.postgresql.org; Mon, 26 Jan 2026 07:10:46 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-2b71557299dso5867254eec.1 for ; Sun, 25 Jan 2026 23:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769411442; x=1770016242; darn=lists.postgresql.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=EERRra3dDZ1e8loXDZX4E9q5vPrgC/sasRahOqfMhLA=; b=EgqkTi9Eg68rxmuqZFSvaqgQnywmk9VyJv7hzzPMOVo5SEu3xUKgT50zgdv6Y4cS9Z z3nCxXP32PkzNBcbOxVuFZdCTbsY7GgiWRXVchih+NCojhUU3VFg7PC5WiUQFP3XQEm8 p3nUC+uXFxczjQVEsuW+K+lA9VgK+8QPu8Onhi6wnPXY+xPfEnW+Fk7vQpe7NjIuZVD6 vVTPs6EFk8He5NcZDZpjgFFsNgCfcm37ChV8ce0KkE0Vd77V1kmSBJaI4a68Sen1zEXq EdPjOcPzlKmjR1im24uTGvz5+HH231SlOEuOQk+N6LddY7L9d27lFmVzVqZwBvt1AhDT xdHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769411442; x=1770016242; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EERRra3dDZ1e8loXDZX4E9q5vPrgC/sasRahOqfMhLA=; b=v7JCHPXw8Heu3jy7Qi9ej4tGoHRatYcQKHPIf9teaAQjK3Rp0zbr6TxOZfDTRHHIVO wfYfq/HccZ2TtQ5Dsq6g7k16DKAXl7mJPpVMD2ouAKlA9RkRAZEhL0uFsCHw8klzFR+q MlIewm/UYHbZin48n8ClMlgSVJLR0sUHdgfYYB0cenRaqiWN+N3B5UB02AzdMRhjk5kp LNDUjdo5hFHfMVq+Ui4d5zuoaCcR2Y+H8t6SZzNWVX4Mogth4hOU6Ty6CO0GnC6k4cbe 8pYWDsW8tJGvtZNA01moCRBjk+Uzc1pyvHYFJYL5tv/DOz2fZMYu4/J2Sm1Oc1wmn0EW RTZw== X-Gm-Message-State: AOJu0YzqtrjuWW0azpdPO5OA5D8gZcwDbTl03J6VL/Gmoey7sebXY+8S JM26yvL1U9iZkHJm7XCYScQsS+6f8B1QtaNa4cW4oEtd+XOhCOKKgF/M X-Gm-Gg: AZuq6aJrPwuTA+mDZgPU/E44ZTCwGR4YTCvO4driW9dOXqmvxae/Kes6wT3WDOAbON5 zuT2WNOaKrFYI9c5ftzjPyvCDXRHXnYGToWMMoOfeiqRa0y9OgLQ5dhwxkBcWJImHgwFRB1t3xt K004kEYmH/iVMREDdcAEUU6UR+Ab9VNONbpM4nWRITNgtPYmBBbP4e2CYCoDGhOjOJ5Tw4g0Md5 +7u7nTCE/Hg9kWgyay86d7MAI/zhtn3gXe+wVN1ZLMdMcLJnflmy1Gv6WKI4R9b4UkJWHSE7sPC tVBwR5JvA/SIJ+gz3/HonMMA9BU82XgCk9siVC4PrtTM6PVLs7bgvC3LgraxoTuAKipqAQX1Ayd vQP1BzlfiYIuLCzz0RVmas813Xuc4NJ9vJoXGCWNumnMcYR7XwRdfVF74a+SKAFUrzuEd1JQa5O nhc/AZ6amqCod+XUbITQ== X-Received: by 2002:a05:7300:3c05:b0:2af:7f2:50b3 with SMTP id 5a478bee46e88-2b7642198e4mr1526701eec.5.1769411441942; Sun, 25 Jan 2026 23:10:41 -0800 (PST) Received: from smtpclient.apple ([64.32.14.230]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73a6b6227sm12240480eec.8.2026.01.25.23.10.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Jan 2026 23:10:40 -0800 (PST) From: Chao Li Message-Id: <16D5D52A-1B99-4371-982E-257C195D2924@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_79E45A74-32B6-4EA1-BF1A-C5B06F65337C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier Date: Mon, 26 Jan 2026 15:10:03 +0800 In-Reply-To: Cc: Postgres hackers To: Zsolt Parragi References: <07773235-2E94-478F-BEF6-38C73B0553B8@gmail.com> X-Mailer: Apple Mail (2.3864.300.41.1.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_79E45A74-32B6-4EA1-BF1A-C5B06F65337C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 23, 2026, at 15:43, Zsolt Parragi = wrote: >=20 > Also, there seems to be no test for partitioned NO INHERIT, since the > patch changes it, it could also add a test case to verify the > behavior. >=20 > rg "INHERIT" | grep "cannot be performed" > src/test/regress/expected/alter_table.out:ERROR: ALTER action INHERIT > cannot be performed on relation "partitioned" >=20 > rg "NO INHERIT" | grep "cannot be performed" > # no result Added a test case. >=20 > tablecmds.c:5202 > case AT_DropInherit: /* NO INHERIT */ > ATSimplePermissions(cmd->subtype, rel, > - ATT_TABLE | ATT_PARTITIONED_TABLE | ATT_FOREIGN_TABLE); > + ATT_TABLE | ATT_FOREIGN_TABLE); > /* This command never recurses */ > + ATPrepChangeInherit(rel); > /* No command-specific prep needed */ >=20 > That last comment seems to be a leftover, it's no longer true with = this change. Deleted the comment. >=20 > tablecmds.c:17289 trailing whitespace (in the empty line) > /* > + * ALTER TABLE INHERIT > + * > + * Add a parent to the child's parents. This verifies that all the = columns and > + * check constraints of the parent appear in the child and that they = have the > + * same data types and expressions. > + * > * Return the address of the new parent relation. > */ >=20 Deleted the whitespace. > tablecmds.c:17860 - this check in ATExecDropInherit is now redundant, > since we already have it in ATPrepChangeInherit No, the check is not redundant. It checks for child partitions, while = ATPrepChangeInherit only blocks partitioned tables. >=20 >> Before the patch: >> ``` >> evantest=3D# ALTER TABLE p_test CLUSTER ON idx_p_test_id; >> ERROR: cannot mark index clustered in partitioned table >=20 > Can we still reach the original error in mark_index_clustered somehow? > I don't see any examples in the test suite, or execution paths when I > have looked at the code, and it can be confusing to see a different > error code/message there. The portioned table check was added to mark_index_clustered with = 05fb5d6. In the commit, the test case "ALTER TABLE clstrpart CLUSTER ON = clstrpart_idx;=E2=80=9D was added as well, so my best guess the check is = now no longer needed. I tried to remove the check, and =E2=80=9Cmake = check=E2=80=9D still passes. However, there is a call path: vacuum -> vacuum_rel -> cluster_rel -> = rebuild_relation -> mark_index_clustered. I am not sure if the check = plays some role there. So, I would leave the check there, maybe use a separate discussion for = removal of the check. PFA v5. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ --Apple-Mail=_79E45A74-32B6-4EA1-BF1A-C5B06F65337C Content-Disposition: attachment; filename=v5-0001-tablecmds-reject-CLUSTER-ON-for-partitioned-table.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v5-0001-tablecmds-reject-CLUSTER-ON-for-partitioned-table.patch" Content-Transfer-Encoding: quoted-printable =46rom=205489e109c0a06cd437d33f72d603e6e01825e794=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Wed,=2021=20Jan=202026=2011:27:03=20+0800=0ASubject:=20[PATCH=20= v5=201/2]=20tablecmds:=20reject=20CLUSTER=20ON=20for=20partitioned=20= tables=0A=20earlier=0A=0AALTER=20TABLE=20...=20CLUSTER=20ON=20and=20SET=20= WITHOUT=20CLUSTER=20are=20not=20supported=20for=0Apartitioned=20tables=20= and=20already=20fail=20today,=20but=20only=20at=20exec=20time.=0A=0A= Reject=20these=20commands=20earlier=20via=20ATSimplePermissions(),=20= matching=20the=0Ahandling=20of=20other=20unsupported=20ALTER=20TABLE=20= actions=20on=20partitioned=20tables=0A(such=20as=20SET=20LOGGED=20/=20= SET=20UNLOGGED).=20This=20centralizes=20the=20relation-kind=0Acheck=20in=20= the=20ALTER=20TABLE=20preparation=20phase,=20improving=20consistency=20= and=0Amaintainability.=0A=0AAs=20a=20result,=20partitioned=20tables=20= now=20report=20the=20standard=20ATSimplePermissions()=0Aerror=20for=20= unsupported=20ALTER=20TABLE=20actions.=0A=0AAuthor:=20Chao=20Li=20= =0AReviewed-by:=20Zsolt=20Parragi=20= =0ADiscussion:=20= https://postgr.es/m/CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g@ma= il.gmail.com=0A---=0A=20src/backend/commands/tablecmds.c=20=20=20=20=20=20= |=202=20+-=0A=20src/test/regress/expected/cluster.out=20|=206=20++++--=0A= =202=20files=20changed,=205=20insertions(+),=203=20deletions(-)=0A=0A= diff=20--git=20a/src/backend/commands/tablecmds.c=20= b/src/backend/commands/tablecmds.c=0Aindex=20f976c0e5c7e..3e9f62e9d37=20= 100644=0A---=20a/src/backend/commands/tablecmds.c=0A+++=20= b/src/backend/commands/tablecmds.c=0A@@=20-5142,7=20+5142,7=20@@=20= ATPrepCmd(List=20**wqueue,=20Relation=20rel,=20AlterTableCmd=20*cmd,=0A=20= =09=09case=20AT_ClusterOn:=09=09/*=20CLUSTER=20ON=20*/=0A=20=09=09case=20= AT_DropCluster:=09/*=20SET=20WITHOUT=20CLUSTER=20*/=0A=20=09=09=09= ATSimplePermissions(cmd->subtype,=20rel,=0A-=09=09=09=09=09=09=09=09= ATT_TABLE=20|=20ATT_PARTITIONED_TABLE=20|=20ATT_MATVIEW);=0A+=09=09=09=09= =09=09=09=09ATT_TABLE=20|=20ATT_MATVIEW);=0A=20=09=09=09/*=20These=20= commands=20never=20recurse=20*/=0A=20=09=09=09/*=20No=20command-specific=20= prep=20needed=20*/=0A=20=09=09=09pass=20=3D=20AT_PASS_MISC;=0Adiff=20= --git=20a/src/test/regress/expected/cluster.out=20= b/src/test/regress/expected/cluster.out=0Aindex=20= 4d40a6809ab..07c52e647f7=20100644=0A---=20= a/src/test/regress/expected/cluster.out=0A+++=20= b/src/test/regress/expected/cluster.out=0A@@=20-492,9=20+492,11=20@@=20= Number=20of=20partitions:=203=20(Use=20\d+=20to=20list=20them.)=0A=20= CLUSTER=20clstrpart;=0A=20ERROR:=20=20there=20is=20no=20previously=20= clustered=20index=20for=20table=20"clstrpart"=0A=20ALTER=20TABLE=20= clstrpart=20SET=20WITHOUT=20CLUSTER;=0A-ERROR:=20=20cannot=20mark=20= index=20clustered=20in=20partitioned=20table=0A+ERROR:=20=20ALTER=20= action=20SET=20WITHOUT=20CLUSTER=20cannot=20be=20performed=20on=20= relation=20"clstrpart"=0A+DETAIL:=20=20This=20operation=20is=20not=20= supported=20for=20partitioned=20tables.=0A=20ALTER=20TABLE=20clstrpart=20= CLUSTER=20ON=20clstrpart_idx;=0A-ERROR:=20=20cannot=20mark=20index=20= clustered=20in=20partitioned=20table=0A+ERROR:=20=20ALTER=20action=20= CLUSTER=20ON=20cannot=20be=20performed=20on=20relation=20"clstrpart"=0A= +DETAIL:=20=20This=20operation=20is=20not=20supported=20for=20= partitioned=20tables.=0A=20DROP=20TABLE=20clstrpart;=0A=20--=20Ownership=20= of=20partitions=20is=20checked=0A=20CREATE=20TABLE=20ptnowner(i=20int=20= unique)=20PARTITION=20BY=20LIST=20(i);=0A--=20=0A2.50.1=20(Apple=20= Git-155)=0A=0A= --Apple-Mail=_79E45A74-32B6-4EA1-BF1A-C5B06F65337C Content-Disposition: attachment; filename=v5-0002-tablecmds-reject-INHERIT-NO-INHERIT-for-partition.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v5-0002-tablecmds-reject-INHERIT-NO-INHERIT-for-partition.patch" Content-Transfer-Encoding: quoted-printable =46rom=203899168c6e709add69a291aa4f781bf47d86cbb1=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Thu,=2022=20Jan=202026=2016:47:58=20+0800=0ASubject:=20[PATCH=20= v5=202/2]=20tablecmds:=20reject=20INHERIT=20/=20NO=20INHERIT=20for=20= partitioned=0A=20tables=20earlier=0A=0AALTER=20TABLE=20...=20INHERIT=20= and=20NO=20INHERIT=20are=20not=20supported=20for=20partitioned=0Atables=20= and=20already=20fail=20today,=20but=20only=20via=20ad-hoc=20checks=20in=20= command-=0Aspecific=20preparation=20code=20or=20later=20at=20execution=20= time.=0A=0AReject=20these=20commands=20earlier=20via=20= ATSimplePermissions(),=20matching=20the=0Ahandling=20of=20other=20= unsupported=20ALTER=20TABLE=20actions=20on=20partitioned=20tables.=0A= This=20centralizes=20relation-kind=20checks=20in=20the=20common=20= permission=20framework=0Aand=20produces=20the=20standard,=20consistent=20= error=20message.=0A=0AWhile=20doing=20this,=20fix=20two=20related=20= issues=20in=20the=20preparation=20logic:=0A-=20The=20header=20comment=20= of=20ATPrepAddInherit=20was=20a=20stale=20copy-paste=20that=0A=20=20= described=20behavior=20no=20longer=20implemented=20there.=0A-=20NO=20= INHERIT=20previously=20didn't=20use=20ATPrepAddInherit,=20causing=20it=20= to=20reach=0A=20=20execution-time=20checks=20unnecessarily.=20= Consolidate=20preparation=20into=20a=0A=20=20shared=20helper=20used=20by=20= both=20INHERIT=20and=20NO=20INHERIT,=20ensuring=20both=20are=0A=20=20= rejected=20uniformly=20and=20as=20early=20as=20possible.=0A=0AAuthor:=20= Chao=20Li=20=0AReviewed-by:=20Zsolt=20Parragi=20= =0ADiscussion:=20= https://postgr.es/m/CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g@ma= il.gmail.com=0A---=0A=20src/backend/commands/tablecmds.c=20=20=20=20=20=20= =20=20=20=20|=2031=20++++++++++++-----------=0A=20= src/test/regress/expected/alter_table.out=20|=2010=20+++++---=0A=20= src/test/regress/sql/alter_table.sql=20=20=20=20=20=20|=20=205=20++--=0A=20= 3=20files=20changed,=2026=20insertions(+),=2020=20deletions(-)=0A=0Adiff=20= --git=20a/src/backend/commands/tablecmds.c=20= b/src/backend/commands/tablecmds.c=0Aindex=203e9f62e9d37..379f4d4ebaf=20= 100644=0A---=20a/src/backend/commands/tablecmds.c=0A+++=20= b/src/backend/commands/tablecmds.c=0A@@=20-686,7=20+686,7=20@@=20static=20= void=20ATExecEnableDisableTrigger(Relation=20rel,=20const=20char=20= *trigname,=0A=20=09=09=09=09=09=09=09=09=09=20=20=20LOCKMODE=20= lockmode);=0A=20static=20void=20ATExecEnableDisableRule(Relation=20rel,=20= const=20char=20*rulename,=0A=20=09=09=09=09=09=09=09=09=09char=20= fires_when,=20LOCKMODE=20lockmode);=0A-static=20void=20= ATPrepAddInherit(Relation=20child_rel);=0A+static=20void=20= ATPrepChangeInherit(Relation=20child_rel);=0A=20static=20ObjectAddress=20= ATExecAddInherit(Relation=20child_rel,=20RangeVar=20*parent,=20LOCKMODE=20= lockmode);=0A=20static=20ObjectAddress=20ATExecDropInherit(Relation=20= rel,=20RangeVar=20*parent,=20LOCKMODE=20lockmode);=0A=20static=20void=20= drop_parent_dependency(Oid=20relid,=20Oid=20refclassid,=20Oid=20= refobjid,=0A@@=20-5194,16=20+5194,16=20@@=20ATPrepCmd(List=20**wqueue,=20= Relation=20rel,=20AlterTableCmd=20*cmd,=0A=20=09=09=09break;=0A=20=09=09= case=20AT_AddInherit:=09=09/*=20INHERIT=20*/=0A=20=09=09=09= ATSimplePermissions(cmd->subtype,=20rel,=0A-=09=09=09=09=09=09=09=09= ATT_TABLE=20|=20ATT_PARTITIONED_TABLE=20|=20ATT_FOREIGN_TABLE);=0A+=09=09= =09=09=09=09=09=09ATT_TABLE=20|=20ATT_FOREIGN_TABLE);=0A=20=09=09=09/*=20= This=20command=20never=20recurses=20*/=0A-=09=09=09= ATPrepAddInherit(rel);=0A+=09=09=09ATPrepChangeInherit(rel);=0A=20=09=09=09= pass=20=3D=20AT_PASS_MISC;=0A=20=09=09=09break;=0A=20=09=09case=20= AT_DropInherit:=09/*=20NO=20INHERIT=20*/=0A=20=09=09=09= ATSimplePermissions(cmd->subtype,=20rel,=0A-=09=09=09=09=09=09=09=09= ATT_TABLE=20|=20ATT_PARTITIONED_TABLE=20|=20ATT_FOREIGN_TABLE);=0A+=09=09= =09=09=09=09=09=09ATT_TABLE=20|=20ATT_FOREIGN_TABLE);=0A=20=09=09=09/*=20= This=20command=20never=20recurses=20*/=0A-=09=09=09/*=20No=20= command-specific=20prep=20needed=20*/=0A+=09=09=09= ATPrepChangeInherit(rel);=0A=20=09=09=09pass=20=3D=20AT_PASS_MISC;=0A=20=09= =09=09break;=0A=20=09=09case=20AT_AlterConstraint:=09/*=20ALTER=20= CONSTRAINT=20*/=0A@@=20-17259,14=20+17259,14=20@@=20= ATExecEnableDisableRule(Relation=20rel,=20const=20char=20*rulename,=0A=20= }=0A=20=0A=20/*=0A-=20*=20ALTER=20TABLE=20INHERIT=0A+=20*=20Prepare=20to=20= change=20inheritance.=0A=20=20*=0A-=20*=20Add=20a=20parent=20to=20the=20= child's=20parents.=20This=20verifies=20that=20all=20the=20columns=20and=0A= -=20*=20check=20constraints=20of=20the=20parent=20appear=20in=20the=20= child=20and=20that=20they=20have=20the=0A-=20*=20same=20data=20types=20= and=20expressions.=0A+=20*=20A=20child=20table=20cannot=20be=20a=20typed=20= table=20or=20a=20partition.=20We=20don't=20need=20to=20check=0A+=20*=20= partitioned=20table=20here,=20because=20it=20has=20been=20blocked=20by=20= ATSimplePermissions=20in=0A+=20*=20ATPrepCmd.=0A=20=20*/=0A=20static=20= void=0A-ATPrepAddInherit(Relation=20child_rel)=0A= +ATPrepChangeInherit(Relation=20child_rel)=0A=20{=0A=20=09if=20= (child_rel->rd_rel->reloftype)=0A=20=09=09ereport(ERROR,=0A@@=20= -17277,14=20+17277,15=20@@=20ATPrepAddInherit(Relation=20child_rel)=0A=20= =09=09ereport(ERROR,=0A=20=09=09=09=09= (errcode(ERRCODE_WRONG_OBJECT_TYPE),=0A=20=09=09=09=09=20errmsg("cannot=20= change=20inheritance=20of=20a=20partition")));=0A-=0A-=09if=20= (child_rel->rd_rel->relkind=20=3D=3D=20RELKIND_PARTITIONED_TABLE)=0A-=09=09= ereport(ERROR,=0A-=09=09=09=09(errcode(ERRCODE_WRONG_OBJECT_TYPE),=0A-=09= =09=09=09=20errmsg("cannot=20change=20inheritance=20of=20partitioned=20= table")));=0A=20}=0A=20=0A=20/*=0A+=20*=20ALTER=20TABLE=20INHERIT=0A+=20= *=0A+=20*=20Add=20a=20parent=20to=20the=20child's=20parents.=20This=20= verifies=20that=20all=20the=20columns=20and=0A+=20*=20check=20= constraints=20of=20the=20parent=20appear=20in=20the=20child=20and=20that=20= they=20have=20the=0A+=20*=20same=20data=20types=20and=20expressions.=0A+=20= *=0A=20=20*=20Return=20the=20address=20of=20the=20new=20parent=20= relation.=0A=20=20*/=0A=20static=20ObjectAddress=0Adiff=20--git=20= a/src/test/regress/expected/alter_table.out=20= b/src/test/regress/expected/alter_table.out=0Aindex=20= ac1a7345d0f..8e1ee3f1389=20100644=0A---=20= a/src/test/regress/expected/alter_table.out=0A+++=20= b/src/test/regress/expected/alter_table.out=0A@@=20-3997,9=20+3997,13=20= @@=20CREATE=20TABLE=20nonpartitioned=20(=0A=20=09a=20int,=0A=20=09b=20= int=0A=20);=0A-ALTER=20TABLE=20partitioned=20INHERIT=20nonpartitioned;=0A= -ERROR:=20=20cannot=20change=20inheritance=20of=20partitioned=20table=0A= -ALTER=20TABLE=20nonpartitioned=20INHERIT=20partitioned;=0A+ALTER=20= TABLE=20partitioned=20INHERIT=20nonpartitioned;=20--=20fail=0A+ERROR:=20=20= ALTER=20action=20INHERIT=20cannot=20be=20performed=20on=20relation=20= "partitioned"=0A+DETAIL:=20=20This=20operation=20is=20not=20supported=20= for=20partitioned=20tables.=0A+ALTER=20TABLE=20partitioned=20NO=20= INHERIT=20nonpartitioned;=20--=20fail=0A+ERROR:=20=20ALTER=20action=20NO=20= INHERIT=20cannot=20be=20performed=20on=20relation=20"partitioned"=0A= +DETAIL:=20=20This=20operation=20is=20not=20supported=20for=20= partitioned=20tables.=0A+ALTER=20TABLE=20nonpartitioned=20INHERIT=20= partitioned;=20--=20ok=0A=20ERROR:=20=20cannot=20inherit=20from=20= partitioned=20table=20"partitioned"=0A=20--=20cannot=20add=20NO=20= INHERIT=20constraint=20to=20partitioned=20tables=0A=20ALTER=20TABLE=20= partitioned=20ADD=20CONSTRAINT=20chk_a=20CHECK=20(a=20>=200)=20NO=20= INHERIT;=0Adiff=20--git=20a/src/test/regress/sql/alter_table.sql=20= b/src/test/regress/sql/alter_table.sql=0Aindex=20= 417202430a5..0241e2796c9=20100644=0A---=20= a/src/test/regress/sql/alter_table.sql=0A+++=20= b/src/test/regress/sql/alter_table.sql=0A@@=20-2397,8=20+2397,9=20@@=20= CREATE=20TABLE=20nonpartitioned=20(=0A=20=09a=20int,=0A=20=09b=20int=0A=20= );=0A-ALTER=20TABLE=20partitioned=20INHERIT=20nonpartitioned;=0A-ALTER=20= TABLE=20nonpartitioned=20INHERIT=20partitioned;=0A+ALTER=20TABLE=20= partitioned=20INHERIT=20nonpartitioned;=20--=20fail=0A+ALTER=20TABLE=20= partitioned=20NO=20INHERIT=20nonpartitioned;=20--=20fail=0A+ALTER=20= TABLE=20nonpartitioned=20INHERIT=20partitioned;=20--=20ok=0A=20=0A=20--=20= cannot=20add=20NO=20INHERIT=20constraint=20to=20partitioned=20tables=0A=20= ALTER=20TABLE=20partitioned=20ADD=20CONSTRAINT=20chk_a=20CHECK=20(a=20>=20= 0)=20NO=20INHERIT;=0A--=20=0A2.50.1=20(Apple=20Git-155)=0A=0A= --Apple-Mail=_79E45A74-32B6-4EA1-BF1A-C5B06F65337C--