Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vi6vD-00FBgl-2p for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 08:17:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vi6vB-00GuUc-2b for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 08:17:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vi6vB-00GuUU-1e for pgsql-hackers@lists.postgresql.org; Tue, 20 Jan 2026 08:17:05 +0000 Received: from mail-dl1-x122b.google.com ([2607:f8b0:4864:20::122b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vi6v8-001NxY-0S for pgsql-hackers@postgresql.org; Tue, 20 Jan 2026 08:17:04 +0000 Received: by mail-dl1-x122b.google.com with SMTP id a92af1059eb24-121bf277922so7016975c88.0 for ; Tue, 20 Jan 2026 00:17:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768897022; x=1769501822; darn=postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+80vDO9fj/5AIIE1YqWalGfAUVL8lT1TqgbizqF40qU=; b=lByAFMdgQa8cySQ3dVIt5cHYOUOqBttI1amMvaoY3d3nuK2Y6nj4rYV+Z95wQdqBCv J5+Yh+B3tri97AXXkZj4YbS1xHn6f2AAOD3KFjutKtdbY5ey3QX7tkRE41i6c9+sRHQZ O+LMKd+1wDpAH8vl1zflEEMrbYKRHHCwYlQxKuwX1mOgimEVDxiK+RKySc6LGm9qeEpC flx6aaELCnrRagsHbdCgkwteI7OknK0kIavzYznKziZWz7kAQjPq9tPDN/Y3diUCvAhL qk911vTr+e74xinQln7U9c77kZTO5ICU3/GEpXXFy7HJRzMJXxLG2eKFnbmuHoBeHhZd 1Ajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768897022; x=1769501822; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+80vDO9fj/5AIIE1YqWalGfAUVL8lT1TqgbizqF40qU=; b=TcejDgDkBJpMAxbt+WjbW1pFCj/+qbg5rz355sKao+TF7wwbNO4f/6OegnE4PB2haS v4mHBVpZyjpdCjZOHXQHpeCG9Bsnveu+vgzUajB+YdtgGN1ihBDxSjhbyaCfZAD9JYaC gbohlwQx+wI/zYdH6vcUgILmlTmodvBeLvfGGPMn3Y+y8NQnHHbKaoXUcmW3/qTGCFh3 0lN1c/lhQQ7eKzaWKxN308OCoLT15rwFREBGvKy/NZ6M7zApBmLa25yCu2SQqrgZzepY AFALI/sXj0WEeoTzbPSpg2FLLDjzTcWbQxcWB4/FmboguzEuiRPCeYe5yI/gLghSm0jH rhIg== X-Gm-Message-State: AOJu0YxfwGSFk7L5KSy+pvCbVr620EGXD5q/KhLrEAhrXXDpPJcYYMCa pixu2OWhcqe6GvZznN0wlQ6y/rgbeI0qSDcQNKEp2lDGTqUdqkWvSq5iTE1nEM5j X-Gm-Gg: AY/fxX4PhH1kbK59GhD4hdSg0SPy9dYZMR1ZyRnZ/PHrQTuOeG8FxyZrDBo6pd+hTzK XL/fe1mNB0MvtTAhanUPpYAo6TfQaFc8qBn+KvwQ70dpDFWSB2SIydl48AfIvhKv0K+jsHrJBcq HgM9HS+OvuZ1syBwxN2XxlqRmo1VE3uJDZ+twBOVTJDehvfSnOGHus2lXc2OkBh5ofuameIHAWB aWrqxTb5EXSb/QMH0L7HiXXWA0sTdm+C+fCXbdPUN0Gx126q0Hgg2qOeM9Ln2aMaWJ0NTY7XY1o wtExk9iW787QQGEFoQokNWTEiG0nCjlfs1GAe6A01z2Bv2PnlTfMk/POyxfWwCVIAY3oAKt/TVE rj2d7io+3T1JS7kdq0knPSP4p03t0JIQvRN8K2hjmepIba+Wdi6is7zdvigY9kVDUh17hWR5dok GBeVAVroPk6oC1l8yl4wXi X-Received: by 2002:a05:7022:48e:b0:119:e569:f60d with SMTP id a92af1059eb24-1244b304b60mr11591851c88.6.1768897021843; Tue, 20 Jan 2026 00:17:01 -0800 (PST) Received: from smtpclient.apple ([142.171.105.12]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244ad740c5sm20681935c88.8.2026.01.20.00.17.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2026 00:17:01 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: Fix accidentally cast away qualifiers From: Chao Li In-Reply-To: Date: Tue, 20 Jan 2026 16:16:26 +0800 Cc: pgsql-hackers Content-Transfer-Encoding: quoted-printable Message-Id: <16F3FF82-6215-4318-9930-842926B3C693@gmail.com> References: To: Peter Eisentraut X-Mailer: Apple Mail (2.3826.700.81.1.4) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Jan 20, 2026, at 15:54, Peter Eisentraut = wrote: >=20 > This patch fixes cases where a qualifier (const, in all cases here) = was dropped by a cast, but the cast was otherwise necessary or = desirable, so the straightforward fix is to add the qualifier into the = cast. >=20 > This was checked with gcc -Wcast-qual, but it doesn't fix all such = warnings, only the trivially fixable = ones.<0001-Fix-accidentally-cast-away-qualifiers.patch> Looks good to me. All changes are const-correctness fixes without = semantic changes. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/