MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 23 Sep 2020 17:13:36 +0900
From: Katsuragi Yuta <btkatsuragiyu@oss.nttdata.com>
To: legrand legrand <legrand_legrand@hotmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Add features to pg_stat_statements
In-Reply-To: <1600500942767-0.post@n3.nabble.com>
References: <0d9f1107772cf5c3f954e985464c7298@oss.nttdata.com>
 <1600500942767-0.post@n3.nabble.com>
Message-ID: <16a262a87492b4f4afc4c5010f8fa631@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Precedence: bulk

On 2020-09-19 16:35, legrand legrand wrote:
> +1 !
> 
> An other way is to log evictions, it provides informations about time 
> and
> amount :
> 
> 	for (i = 0; i < nvictims; i++)
> 	{
> 		hash_search(pgssp_hash, &entries[i]->key, HASH_REMOVE, NULL);
> 	}
> 
> 	pfree(entries);
> 
> 	/* trace when evicting entries, if appening too often this can slow 
> queries
> ...
> 	 * increasing pg_stat_sql_plans.max value could help */
> 	 ereport(LOG,
> 		(errmsg("pg_stat_sql_plans evicting %d entries", nvictims),
> 		errhidecontext(true), errhidestmt(true)));
> 
> 
> 
> --
> Sent from: 
> https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html

Thank you for your comments!
In addition to providing a view that is like a summary of history,
logging might be a good choice.

Regards,
Katsuragi Yuta