From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
cc: Amit Kapila <amit.kapila16@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Rahila Syed <rahilasyed90@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>
Subject: Re: Column Filtering in Logical Replication
In-reply-to: <4f832e27-20a4-964a-fafd-edf39e0ae883@enterprisedb.com>
References: <202201120041.p24wvsfcsope@alvherre.pgsql>
 <d26d24dd-2fab-3c48-0162-2b7f84a9c893@enterprisedb.com>
 <CAA4eK1JJ5qgqbjfYQU9F4R1+OABxec-DQechQXus0fanDjaAVg@mail.gmail.com>
 <OS0PR01MB571614E4A39DD33669D5AFD6940A9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <e4b0fb99-3d74-7333-1e71-74f990b641ee@enterprisedb.com>
 <78b8d385-57cb-9a3f-cfe5-9f300f15eced@enterprisedb.com>
 <822a8e40-287c-59ff-0ea9-35eb759f4fe6@enterprisedb.com>
 <CAA4eK1J9UDnM-xN7viu4eO_DDL_PqMG9F6ZsskqEU7snujXi+A@mail.gmail.com>
 <2b8471f9-3849-c91f-ef82-9181d4bca0a7@enterprisedb.com>
 <CAA4eK1KUpOnFam+2bBuGGX-_pZbmO_ShJV6G=GT-RyM7gQSvWg@mail.gmail.com>
 <16e83ce3-8415-b732-37b2-c3329a2c13a1@enterprisedb.com>
 <9c0dd1f3-c1b9-9c10-eca6-35f22104434a@enterprisedb.com>
 <bded66cd-393d-77bf-44ee-2cbebcc70d7c@enterprisedb.com>
 <05a7a760-ba3a-fcff-d7d1-3afb47ea0f7d@enterprisedb.com>
 <16b01452-fe77-7b02-22c0-1711485e396e@enterprisedb.com>
 <CAA4eK1LahG9b8zxOjgC-KeMETYMA=aDZM4-Y0GB9M4cUGOgmwA@mail.gmail.com>
 <4f832e27-20a4-96!
 4a-fafd-edf39e0ae883@enterprisedb.com>
Comments: In-reply-to Tomas Vondra <tomas.vondra@enterprisedb.com>
	message dated "Sat, 26 Mar 2022 01:18:08 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <170548.1648330634.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 26 Mar 2022 17:37:14 -0400
Message-ID: <170549.1648330634@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/170549.1648330634%40sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> I went over the patch again, polished the commit message a bit, and
> pushed. May the buildfarm be merciful!

Initial results aren't that great.  komodoensis[1], petalura[2],
and snapper[3] have all shown variants of

#   Failed test 'partitions with different replica identities not replicat=
ed correctly'
#   at t/031_column_list.pl line 734.
#          got: '2|4|
# 4|9|'
#     expected: '1||5
# 2|4|
# 3||8
# 4|9|'
# Looks like you failed 1 test of 34.
[18:19:36] t/031_column_list.pl ............... =

Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/34 subtests =


snapper reported different actual output than the other two:
#          got: '1||5
# 3||8'

The failure seems intermittent, as both komodoensis and petalura
have also passed cleanly since the commit (snapper's only run once).

This smells like an uninitialized-variable problem, but I've had
no luck finding any problem under valgrind.  Not sure how to progress
from here.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dkomodoensis&=
dt=3D2022-03-26%2015%3A54%3A04
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpetalura&dt=3D=
2022-03-26%2004%3A20%3A04
[3] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dsnapper&dt=3D=
2022-03-26%2018%3A46%3A28