Message-ID: <171299a1-6110-43ca-bb79-66b82e0baa12@gmail.com>
Date: Mon, 4 Sep 2023 14:14:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Autogenerate some wait events code and documentation
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <ZKpjawSAHIjYV2+Q@paquier.xyz>
 <9682e829-4120-a3d5-4834-d909ad4b49d8@gmail.com>
 <ZKuVKPB+rwYH5cuw@paquier.xyz>
 <e318fee2-ab72-9d71-6b8b-c99753f4cecc@gmail.com>
 <ZK9S3jFEV1X797Ll@paquier.xyz> <ZLDT0kOh0tuh6IpV@paquier.xyz>
 <20230716192120.t53prl2uruingo6z@awork3.anarazel.de>
 <ZLSWUh3dpZPlvrso@paquier.xyz> <ZOxVHQwEC/9X/p/z@paquier.xyz>
 <6dc1587f-2ca6-4dd6-b389-94a05912fda5@gmail.com>
 <ZO2TLRFLT73IFN8T@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZO2TLRFLT73IFN8T@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/171299a1-6110-43ca-bb79-66b82e0baa12%40gmail.com>
Precedence: bulk

Hi,

On 8/29/23 8:41 AM, Michael Paquier wrote:
> On Tue, Aug 29, 2023 at 08:17:10AM +0200, Drouvot, Bertrand wrote:
> That may be a bug in the matrix because of bb90022, as git am can be
> easily pissed. 

git am does not complain anymore.


+       # Generate the element name for the enums based on the
+       # description.  The C symbols are prefixed with "WAIT_EVENT_".

Nit: 2 whitespaces before "The C"

     # Build the descriptions.  There are in camel-case.
     # LWLock and Lock classes do not need any modifications.

Nit: 2 whitespaces before "There are in camel"

+       my $waiteventdescription = '';
+       if (   $waitclassname eq 'WaitEventLWLock'

Nit: Too many whitespace after the "if (" ?? (I guess pgperltidy would
fix it).

> I have double-checked the docs generated, while on it, and I am not
> seeing anything missing, particularly for the LWLock and Lock parts..

I did compare the output of select * from pg_wait_events order by 1,2 and
ignored the case (with and without the patch series).

Then, the only diff is:

< Client,WalSenderWaitWal,Waiting for WAL to be flushed in WAL sender process
---
> Client,WalSenderWaitForWAL,Waiting for WAL to be flushed in WAL sender process

That said, it looks good to me.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com