From: Sergei Kornilov <sk@zsrv.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Ildar Musin <i.musin@postgrespro.ru>,
	Stephen Frost <sfrost@snowman.net>,
	Robert Haas <robertmhaas@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
In-Reply-To: <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
References: <880511520351578@web5j.yandex.ru>
 <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
MIME-Version: 1.0
Message-Id: <1715451520361128@web26o.yandex.ru>
Date: Tue, 06 Mar 2018 21:32:08 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Precedence: bulk

Hello

> You should be able to use an event trigger that raises a message when
> table_rewrite is hit, to notify the test driver that a rewrite happens.
Here is no table rewrite, only verify. So here EventTriggerTableRewrite is not called. Or i missed something?

> ISTM that depending on DEBUG messages is bad because debugging lines
> added elsewhere will make your tests fail;
I agree and this is reason why i not used DEBUG message in tests as was proposed. I found INFO messages in tests and decided that this was an acceptable option year ago.

> and INFO is generally frowned upon (I, for one, would frown upon an INFO message raised by ALTER
> TABLE, for sure.) so let's not do that either.
In this case we need remove INFO from ALTER TABLE ATTACH PARTITION code and tests. I think is a bad idea of using different rules for same stuff, right? Probably i can do this work too.

But it is necessary to decide how the test should look.

regards, Sergei