Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7p30-0004j9-Hh for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Mar 2019 22:23:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h7p2z-0000cc-6B for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Mar 2019 22:23:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7p2y-0000cU-S3 for pgsql-hackers@lists.postgresql.org; Sat, 23 Mar 2019 22:23:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7p2w-0008G2-Bi for pgsql-hackers@postgresql.org; Sat, 23 Mar 2019 22:23:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2NMMdcs017187; Sat, 23 Mar 2019 18:22:39 -0400 From: Tom Lane To: Chapman Flack cc: Ryan Lambert , pgsql-hackers@postgresql.org Subject: Re: Fix XML handling with DOCTYPE In-reply-to: <5C96AAD4.1090006@anastigmatix.net> References: <5C8D5D16.7090206@anastigmatix.net> <23319.1552769738@sss.pgh.pa.us> <5C8D6681.4070504@anastigmatix.net> <24203.1552771272@sss.pgh.pa.us> <5C8D79AF.7010204@anastigmatix.net> <5146.1552837534@sss.pgh.pa.us> <5C8E7FC0.8040401@anastigmatix.net> <31664.1552842991@sss.pgh.pa.us> <5C8E8E2F.9050600@anastigmatix.net> <25228.1552849567@sss.pgh.pa.us> <5C8ECAA4.3090301@anastigmatix.net> <5C8FD4EE.7090107@anastigmatix.net> <12135.1553374744@sss.pgh.pa.us> <5C96AAD4.1090006@anastigmatix.net> Comments: In-reply-to Chapman Flack message dated "Sat, 23 Mar 2019 17:53:24 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17185.1553379759.1@sss.pgh.pa.us> Date: Sat, 23 Mar 2019 18:22:39 -0400 Message-ID: <17186.1553379759@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Chapman Flack writes: > On 03/23/19 16:59, Tom Lane wrote: >> You're not really validating that the input >> is something that libxml would accept, unless its processing of XML PIs >> is far stupider than I would expect it to be. > Out of curiosity, what further processing would you expect libxml to do? Hm, I'd have thought it'd try to parse the arguments to some extent, but maybe not. Does everybody reimplement attribute parsing for themselves when using PIs? regards, tom lane