pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedUnused entry in pg_opfamily
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2018-11-05 55f3d10296 Remove unreferenced pg_opfamily entry.
* Unused entry in pg_opfamily
@ 2018-11-05 01:02 Tom Lane <tgl@sss.pgh.pa.us>
2018-11-05 01:12 ` Re: Unused entry in pg_opfamily Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 2+ messages in thread
From: Tom Lane @ 2018-11-05 01:02 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
I happened to notice that the pg_opfamily entry with OID 4035
(jsonb_ops for GIST) is not referenced anywhere; apparently it
was put in in anticipation of support that never materialized.
We still pass make check-world if it's removed.
Getting rid of it seems like a no-brainer, but it surprised me
a bit that none of our automated crosschecks had noticed this.
It looks like the reason is that all the amvalidate logic is
driven off pg_opclass entries, and so an opfamily that contains
no opclass is never examined.
We should, therefore, at least add an oprsanity check for
opfamilies without opclasses. I wonder how far it's worth
going to check for other orphaned catalog entries.
regards, tom lane
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Unused entry in pg_opfamily
2018-11-05 01:02 Unused entry in pg_opfamily Tom Lane <tgl@sss.pgh.pa.us>
@ 2018-11-05 01:12 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2018-11-05 01:12 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@lists.postgresql.org
On Sun, Nov 04, 2018 at 08:02:25PM -0500, Tom Lane wrote:
> We should, therefore, at least add an oprsanity check for
> opfamilies without opclasses. I wonder how far it's worth
> going to check for other orphaned catalog entries.
+1.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-11-05 01:12 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 01:02 Unused entry in pg_opfamily Tom Lane <tgl@sss.pgh.pa.us>
2018-11-05 01:12 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox