From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org,
        david@justatheory.com, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: abi-compliance-check failure due to recent changes to
 pg_{clear,restore}_{attribute,relation}_stats()
In-reply-to: 
 <CAH2-WznQY7UaGGdAgg0crnJ8j1R3MW8rMqEynDBMTio+7WAYXA@mail.gmail.com>
References: <aPJ03E2itovDBcKX@nathan> <1713509.1760721320@sss.pgh.pa.us>
 <aPKFmL8VjOKNVLcw@nathan> <1723302.1760726712@sss.pgh.pa.us>
 <aPKUzk2xFhZBbWmz@nathan>
 <CAH2-WznQY7UaGGdAgg0crnJ8j1R3MW8rMqEynDBMTio+7WAYXA@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Fri, 17 Oct 2025 15:20:55 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1728667.1760729456.1@sss.pgh.pa.us>
Date: Fri, 17 Oct 2025 15:30:56 -0400
Message-ID: <1728668.1760729456@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1728668.1760729456%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> That would require parsing the file and understanding that any
> compliance failures associated with a given commit should be
> suppressed. But that seems decidedly nontrivial to me.

No, I do not think there is any expectation of that.  The idea of
this file IMO is to record a "blessed" commit which the buildfarm
should compare branch tip to.  Nathan is proposing that the file
should also have the function of recording all previous blessed
commits for historical purposes.  That's not essential but I can
see some value in it.  All it requires from the buildfarm code
is that it take the first non-comment entry in the file.

			regards, tom lane