From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jesper Pedersen <jesper.pedersen@redhat.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Ashutosh Sharma <ashu.coek88@gmail.com>,
        Mithun Cy <mithun.cy@enterprisedb.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Jeff Janes <jeff.janes@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pageinspect: Hash index support
In-reply-to: <b2c7d6f0-edc3-6fce-cbbe-82ca277e2f22@redhat.com>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
 <CA+TgmoaLV_-aw9Jx2x7E0zqwoWTT=LY9X4-_SkRia1atJ0GPWA@mail.gmail.com>
 <CAE9k0P=MVtGPJzdSNGy0hwVZp=VE2ghf7cQWhvgqLVv0ANcahw@mail.gmail.com>
 <d92c25dc-a42d-d56e-5228-cc79b424fe99@redhat.com>
 <CAA4eK1JDXuOUsx-x0FzOJJGX6Xa4jOL80y62ScZLqdEOuGBXMA@mail.gmail.com>
 <CAE9k0PnA=CnkaBCYfkL9jMJ5yNm5nEad=Cx2x8ED8Yo2j8+pzA@mail.gmail.com>
 <4f9c865b-0f79-83a7-a540-1533706c24ee@redhat.com>
 <CAE9k0PkewVp0HzkaiztjiUma8tsZLMi+Gx==4Wszj3tR8A0acA@mail.gmail.com>
 <CAD__OugG-LRWN-dFpdwr62v9f4HWDRtAdwzHXVfNAU_fSR-pRw@mail.gmail.com>
 <CA+TgmoZUjrVy52TUU3b_Q5L6jcrt7w5R4qFwMXdeCuKQBmYWqQ@mail.gmail.com>
 <CAE9k0Pke046HKYfuJGcCtP77NyHrun7hBV-v20a0TW4CUg4H+A@mail.gmail.com>
 <CA+TgmoaTRh4B75CguW=pWLjJ=LLBBH-=Anz6pcPFn5jx_VQPQQ@mail.gmail.com>
 <CAE9k0Pnkx0mxAejDX6S6EBaNAgv=Fj9DoEx7B0vy=d6kmzcNzQ@mail.gmail.com>
 <CA+Tgmoa6cKSV26d_XMwqw2Hwh_hk5wZpuVJg18WTVQ-L6vr+Aw@mail.gmail.com>
 <408828d9-e1b1-16b0-63fe-f2aeea83bc5c@redhat.com> <b2c7d6f0-edc3-6fc!
 e-cbbe-82ca277e2f22@redhat.com>
Comments: In-reply-to Jesper Pedersen <jesper.pedersen@redhat.com>
	message dated "Fri, 03 Feb 2017 07:45:56 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17310.1486134714.1@sss.pgh.pa.us>
Date: Fri, 03 Feb 2017 10:11:54 -0500
Message-ID: <17311.1486134714@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

BTW, the buildfarm is still crashing on ia64 and sparc64 members.
I believe this is the same problem addressed in 84ad68d64 for
pageinspect's GIN functions, to wit, the payload of a "bytea"
is not maxaligned, so machines that care about alignment won't be
happy when trying to fetch 64-bit values out of a bytea page image.

Clearly, the fix should be to start using the get_page_from_raw()
function that Peter introduced in that patch.  But it's static in
ginfuncs.c, which I thought was a mistake at the time, and it's
proven so now.

contrib/pageinspect actually seems to lack *any* infrastructure
for sharing functions across modules.  It's time to remedy that.
I propose inventing "pageinspect.h" to hold commonly visible
declarations, and moving get_page_from_raw() into rawpage.c,
which seems like a reasonably natural home for it.  (Alternatively,
we could invent a pageinspect.c file to hold utility functions,
but that might be overkill.)

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers